On 8/10/21 6:13 AM, Ashish Kalra wrote: > Hello Tom, > > On Mon, Aug 09, 2021 at 09:29:29AM -0500, Tom Lendacky wrote: >> On 8/2/21 7:33 AM, Ashish Kalra wrote: >> >> Should there be an "ASSERT_EFI_ERROR (Status)" after the DEBUG call? >> > > I don't think we should do an assert here and abort booting, failure > here will simply disable live migration support but i don't think that > it is such a fatal error that we should abort booting because of that. > > OTOH, if there is a failure when doing page encryption status hypercalls > then aborting boot makes sense as guest page encryption status tracking > may be critical for multiple guest operations and not only live > migration.
Makes sense. Thanks, Tom > > Thanks, > Ashish > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79029): https://edk2.groups.io/g/devel/message/79029 Mute This Topic: https://groups.io/mt/84609858/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
