Acked-by: Ray Ni <ray...@intel.com> I will depend on tool owner to review the tool configuration change making sure that the correct section name is chosen for different C compilers.
Thanks, Ray > -----Original Message----- > From: Marvin Häuser <mhaeu...@posteo.de> > Sent: Monday, August 9, 2021 5:51 PM > To: devel@edk2.groups.io > Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Kumar, > Rahul1 <rahul1.ku...@intel.com>; Vitaly Cheptsov > <vit9...@protonmail.com> > Subject: [PATCH v2 2/2] UefiCpuPkg/BaseUefiCpuLib: Use toolchain-specific > rodata section name > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 > > Correctly define the read-only data sections with the > toolchain-specific section name. This hardens image permission > security and may save image space. > > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Cc: Vitaly Cheptsov <vit9...@protonmail.com> > Signed-off-by: Marvin Häuser <mhaeu...@posteo.de> > --- > UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.nasm | 2 +- > UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.nasm > b/UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.nasm > index 5e27cc325012..cfb8bf4a5ae0 100644 > --- a/UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.nasm > +++ b/UefiCpuPkg/Library/BaseUefiCpuLib/Ia32/InitializeFpu.nasm > @@ -6,7 +6,7 @@ > ;* > > > ;------------------------------------------------------------------------------ > > > > - SECTION .rodata > > + SECTION RODATA_SECTION_NAME > > > > ; > > ; Float control word initial value: > > diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm > b/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm > index 8485b4713548..3c976a21e391 100644 > --- a/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm > +++ b/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm > @@ -6,7 +6,7 @@ > ;* > > > ;------------------------------------------------------------------------------ > > > > - SECTION .rodata > > + SECTION RODATA_SECTION_NAME > > ; > > ; Float control word initial value: > > ; all exceptions masked, double-extended-precision, round-to-nearest > > -- > 2.31.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79001): https://edk2.groups.io/g/devel/message/79001 Mute This Topic: https://groups.io/mt/84764907/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
