When merging, change the patch subject a little to: MdeModulePkg PCD: Print which PCD was unable to be found
Pushed via: PR - https://github.com/tianocore/edk2/pull/1825 Commit - https://github.com/tianocore/edk2/commit/83b43c4cb17ec8c9fd2bb5843bf66e5961f28c82 Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Daniel > Schaefer > Sent: Wednesday, July 14, 2021 12:43 PM > To: devel@edk2.groups.io > Cc: Daniel Schaefer <daniel.schae...@hpe.com>; Wang, Jian J > <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Bi, Dandan > <dandan...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn> > Subject: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Print which PCD was > unable to be found > > When reaching the assert, it can't be debugged because the PCD is unknown. > Therefore the PCD's GUID and token number should be printed. > > Signed-off-by: Daniel Schaefer <daniel.schae...@hpe.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Dandan Bi <dandan...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > --- > MdeModulePkg/Universal/PCD/Dxe/Service.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c > b/MdeModulePkg/Universal/PCD/Dxe/Service.c > index ea7edc3cbb1c..badeec8c97f0 100644 > --- a/MdeModulePkg/Universal/PCD/Dxe/Service.c > +++ b/MdeModulePkg/Universal/PCD/Dxe/Service.c > @@ -3,7 +3,7 @@ > > Copyright (c) 2014, Hewlett-Packard Development Company, L.P.<BR> > Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> > -(C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > +(C) Copyright 2016-2021 Hewlett Packard Enterprise Development LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -1610,6 +1610,7 @@ GetExPcdTokenNumber ( > } > } > > + DEBUG ((DEBUG_ERROR, "%a: Failed to find PCD with GUID: %g and token > + number: %d\n", __FUNCTION__, Guid, ExTokenNumber)); > ASSERT (FALSE); > > return 0; > -- > 2.31.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77997): https://edk2.groups.io/g/devel/message/77997 Mute This Topic: https://groups.io/mt/84195540/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
