In ServerManagment.h, please make sure the newly added macros and structure names are EFI/PI spec defined. If they are not, please remove "EFI_" prefix from the names. With that: Reviewed-by: Sai Chaganty <rangasai.v.chaga...@intel.com>
-----Original Message----- From: Chiu, Chasel <chasel.c...@intel.com> Sent: Thursday, July 08, 2021 7:41 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; Oram, Isaac W <isaac.w.o...@intel.com> Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> Cc: Liming Gao <gaolim...@byosoft.com.cn> Cc: Isaac Oram <isaac.w.o...@intel.com> Signed-off-by: Chasel Chiu <chasel.c...@intel.com> --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf | 1 + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 11 +++++++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h | 17 +++++++++++++++++ 3 files changed, 29 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf index 0ef2c18116..bd995ef25f 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf @@ -42,6 +42,7 @@ DebugLib IoLib TimerLib + ReportStatusCodeLib [Guids] diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc index a1fcefad70..05a7d4f0af 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc @@ -59,6 +59,12 @@ PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf + + ##################################### + # IPMI Feature Package + ##################################### + IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/PeiIpmiBaseLib.inf [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] ####################################### @@ -72,6 +78,11 @@ UefiLib|MdePkg/Library/UefiLib/UefiLib.inf UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf + ##################################### + # IPMI Feature Package + ##################################### + IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/IpmiBaseLib.inf + ################################################################################ # # Component section - list of all components that need built for this feature. diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h index 244b86e91a..7591f33aba 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h @@ -149,6 +149,15 @@ typedef enum { #define UPPER_NON_RECOVER_GOING_LOW 0x400 #define UPPER_NON_RECOVER_GOING_HI 0x800 +// +// Definitions for Get BMC Execution Context +// +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 +// +// Current Execution Context responses +// +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 + // // Server Management COM Addressing types // @@ -318,6 +327,14 @@ typedef struct { UINT16 IoBasePort; } IPMI_HOB_DATA; +// +// Constants and Structure definitions for "Get Device ID" command to follow here +// +typedef struct { + UINT8 CurrentExecutionContext; + UINT8 PartitionPointer; +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; + // // COM Layer Callback // -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77627): https://edk2.groups.io/g/devel/message/77627 Mute This Topic: https://groups.io/mt/84069084/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
