Hi Sean, Maintainers.txt is a standard file format defined by TianoCore. Format is in file header. The intent is for the file format to be consumable by tools and developers.
I reviewed CODEOWERS feature. It has limitations that do not match the EDK II development process. Mike > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Sean > Sent: Thursday, July 8, 2021 12:55 PM > To: [email protected]; Kinney, Michael D <[email protected]> > Cc: Andrew Fish <[email protected]>; Laszlo Ersek <[email protected]>; Leif > Lindholm <[email protected]>; Feng, Bob C > <[email protected]>; Liming Gao <[email protected]>; Chen, > Christine <[email protected]> > Subject: Re: [edk2-devel] [Patch V2 0/3] Add GitHub IDs to Maintainers.txt > > Is Maintainers.txt a standard file used by standard tools or just a > custom file for the GetMaintainer.py script? > > There is a similar idea used by github (and maybe others) called > CODEOWNERS. See > https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code- > owners > > This allows github to auto assign reviewers to a PR. Would it make > sense to try to align? > > Thanks > Sean > > > > On 7/8/2021 12:50 PM, Michael D Kinney wrote: > > New in V2 > > ========= > > * Maintainers.txt updates > > * Remove content after email address from standard output > > * Fix --lookup compatibility with '\' path separators. > > > > Update GetMaintainer.py to allow a GitHub ID after the email address > > for maintainers and reviewers and update Maitainers.txt with GitHub IDs. > > > > The GitHub ID will be used to help autotate the PR reviewer assignments. > > > > Cc: Andrew Fish <[email protected]> > > Cc: Laszlo Ersek <[email protected]> > > Cc: Leif Lindholm <[email protected]> > > Cc: Bob Feng <[email protected]> > > Cc: Liming Gao <[email protected]> > > Cc: Yuwei Chen <[email protected]> > > Signed-off-by: Michael D Kinney <[email protected]> > > > > Michael D Kinney (3): > > BaseTools/Scripts: Fix GetMaintainer.py line endings > > BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines > > Maintainers.txt: Add GitHub IDs > > > > BaseTools/Scripts/GetMaintainer.py | 382 +++++++++++++++-------------- > > Maintainers.txt | 282 +++++++++++---------- > > 2 files changed, 331 insertions(+), 333 deletions(-) > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77617): https://edk2.groups.io/g/devel/message/77617 Mute This Topic: https://groups.io/mt/84076273/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
