On 7/6/21 6:02 PM, Laszlo Ersek wrote: > On 07/06/21 11:53, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daude <phi...@redhat.com> >> >> The Print service driver is not used by OVMF, remove it. >> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Brijesh Singh <brijesh.si...@amd.com> >> Cc: Erdem Aktas <erdemak...@google.com> >> Cc: James Bottomley <j...@linux.ibm.com> >> Cc: Jiewen Yao <jiewen....@intel.com> >> Cc: Min Xu <min.m...@intel.com> >> Cc: Tom Lendacky <thomas.lenda...@amd.com> >> Suggested-by: Laszlo Ersek <ler...@redhat.com> >> Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com> >> --- >> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - >> OvmfPkg/OvmfPkgIa32.dsc | 1 - >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 - >> OvmfPkg/OvmfPkgX64.dsc | 1 - >> OvmfPkg/AmdSev/AmdSevX64.fdf | 1 - >> OvmfPkg/OvmfPkgIa32.fdf | 1 - >> OvmfPkg/OvmfPkgIa32X64.fdf | 1 - >> OvmfPkg/OvmfPkgX64.fdf | 1 - >> 8 files changed, 8 deletions(-) > > I think the same applies to all of the DSC/FDF files (basically, > "platforms") under OvmfPkg -- including Bhyve and Xen.
Sorry I was sitting on an incorrect branch :( > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf > > However, none of the OVMF DSC files contain such a PrintLib class > resolution, so none of the OVMF platforms need PrintDxe. Thanks! > > Thanks, > Laszlo > >> >> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc >> index 1d487befae08..d1974b4a6873 100644 >> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc >> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc >> @@ -722,7 +722,6 @@ [Components] >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> } >> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >> index f53efeae7986..dff4b97b37c0 100644 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -816,7 +816,6 @@ [Components] >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> } >> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >> index b3662e17f256..f3df655c990e 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >> @@ -830,7 +830,6 @@ [Components.X64] >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> } >> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> index 0a237a905866..dc9a2720f9b2 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -828,7 +828,6 @@ [Components] >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> } >> - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf >> index 9977b0f00a18..42f120d016e1 100644 >> --- a/OvmfPkg/AmdSev/AmdSevX64.fdf >> +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf >> @@ -234,7 +234,6 @@ [FV.DXEFV] >> INF MdeModulePkg/Application/UiApp/UiApp.inf >> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf >> index 04b41445ca34..031eb4225c53 100644 >> --- a/OvmfPkg/OvmfPkgIa32.fdf >> +++ b/OvmfPkg/OvmfPkgIa32.fdf >> @@ -254,7 +254,6 @@ [FV.DXEFV] >> INF MdeModulePkg/Application/UiApp/UiApp.inf >> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf >> index 02fd8f0c413e..7194f08e6024 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.fdf >> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf >> @@ -255,7 +255,6 @@ [FV.DXEFV] >> INF MdeModulePkg/Application/UiApp/UiApp.inf >> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf >> index 5fa8c0895808..b304e3149d4f 100644 >> --- a/OvmfPkg/OvmfPkgX64.fdf >> +++ b/OvmfPkg/OvmfPkgX64.fdf >> @@ -267,7 +267,6 @@ [FV.DXEFV] >> INF MdeModulePkg/Application/UiApp/UiApp.inf >> INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf >> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77557): https://edk2.groups.io/g/devel/message/77557 Mute This Topic: https://groups.io/mt/84016919/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-