Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > Kubacki > Sent: Saturday, June 26, 2021 5:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com> > Subject: [edk2-devel] [edk2-platforms][PATCH v4 16/41] CoffeelakeSiliconPkg: > Use IntelSiliconPkg BIOS area and ucode PCDs > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 > > Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are > declared in IntelSiliconPkg.dec. > > The previous PCDs are removed from CoffeelakeSiliconPkg.dec. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > --- > > Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLib. > inf | 4 ++-- > Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec > | 5 ----- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLi > b.inf > b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLi > b.inf > index f793432bf049..ca57b5b31e0a 100644 > --- > a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLi > b.inf > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/Pei > +++ CpuPolicyLib.inf > @@ -48,8 +48,8 @@ [Ppis] > gSiPreMemPolicyPpiGuid ## CONSUMES > > [FixedPcd] > -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase > -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize > +gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase > +gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize > > [Pcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode ## Produces diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec > b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec > index 6cf894498d6b..5ea6fbb28411 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec > @@ -474,13 +474,8 @@ [PcdsFixedAtBuild] > ## NOTE: The size restriction may be changed in next generation processor. > ## Please refer to Processor BWG for detail. > ## > - > gSiPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF800000|UINT32|0x10000 > 001 > -gSiPkgTokenSpaceGuid.PcdBiosSize|0x00800000|UINT32|0x10000002 > > gSiPkgTokenSpaceGuid.PcdTemporaryRamBase|0xfef00000|UINT32|0x000100 > 28 > gSiPkgTokenSpaceGuid.PcdTemporaryRamSize|0x2000|UINT32|0x00010029 > - > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE60000|UINT32|0x3000 > 0004 > - > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A0000|UINT32|0x3000 > 0005 > - > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x00660000|UINT32|0x30 > 000006 > > ## > ## PcdEfiGcdAllocateType is using for EFI_GCD_ALLOCATE_TYPE selection > -- > 2.28.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#77113): https://edk2.groups.io/g/devel/message/77113 > Mute This Topic: https://groups.io/mt/83794797/1777047 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.c...@intel.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77153): https://edk2.groups.io/g/devel/message/77153 Mute This Topic: https://groups.io/mt/83794797/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
