Hi Siva, I am fine with the patch per se, but I still have problems applying it. Have you tried following my suggestions from our meeting?
Thanks, Maciej On 24-Jun-21 09:33, INDIA\sivaramann wrote:
Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver. In this function any non allowed events are recieved as input it will exit in beginning itself. But the switch case handling the default and Dhcp4SendRequest which is not reachable. Signed-off-by: Sivaraman <sivaram...@ami.com> --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c index fb63cf61a9..e85176f9bb 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c @@ -1256,19 +1256,10 @@ PxeBcDhcp4CallBack (// // Cache the DHCPv4 discover packet to mode data directly. - // It need to check SendGuid as well as Dhcp4SendRequest. + // It need to check SendGuid. // CopyMem (&Mode->DhcpDiscover.Dhcpv4, &Packet->Dhcp4, Packet->Length);- case Dhcp4SendRequest: - if (Packet->Length > PXEBC_DHCP4_PACKET_MAX_SIZE) { - // - // If the to be sent packet exceeds the maximum length, abort the DHCP process. - // - Status = EFI_ABORTED; - break; - } - if (Mode->SendGUID) { // // Send the system Guid instead of the MAC address as the hardware address if required. @@ -1332,6 +1323,7 @@ PxeBcDhcp4CallBack ( break;default: + ASSERT (FALSE); break; }
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77087): https://edk2.groups.io/g/devel/message/77087 Mute This Topic: https://groups.io/mt/83760651/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
