回复: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to convert the image to ACPI data

[gaoliming]

Laszlo:
  Thanks for your reminder. When I merge this change, I add the regression 
commit info in the commit message. 

  This change is merged at ddb3fdbef30de5a2946f9bd51060e8d5b1987aef.

Thanks
Liming
> -----邮件原件-----
> 发件人: Laszlo Ersek <ler...@redhat.com>
> 发送时间: 2021年6月7日 23:19
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
> 抄送: Ray Ni <ray...@intel.com>; Leif Lindholm <l...@nuviainc.com>; Bob
> Feng <bob.c.f...@intel.com>
> 主题: Re: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to
> convert the image to ACPI data
> 
> On 06/05/21 03:18, gaoliming wrote:
> > With GCC49 tool chain, aslc file is compiled into elf image.
> > But, its text section has no CODE attribute. So, it can't be detected
> > by new GenFw tool.For this type file. its text section is not required.
> > Its data section will be converted to acpi table.
> >
> > This fix is to remove assert check when the generated image is ACPI data.
> >
> > Signed-off-by: Liming Gao <gaolim...@byosoft.com.cn>
> > Cc: Ray Ni <ray...@intel.com>
> > Cc: Leif Lindholm <l...@nuviainc.com>
> > Cc: Bob Feng <bob.c.f...@intel.com>
> > ---
> >  This patch has been verified on GCC49 for AARCH64 platform.
> >
> >  BaseTools/Source/C/GenFw/Elf32Convert.c | 2 +-
> >  BaseTools/Source/C/GenFw/Elf64Convert.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> If this is a regression, then the commit message should please identify
> the commit that introduced the regression. We usually do this with:
> 
> Fixes: ....
> 
> Thanks
> Laszlo
> 
> >
> > diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c
> b/BaseTools/Source/C/GenFw/Elf32Convert.c
> > index 7c8a065678ac..314f8233234d 100644
> > --- a/BaseTools/Source/C/GenFw/Elf32Convert.c
> > +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c
> > @@ -435,7 +435,7 @@ ScanSections32 (
> >      }
> >    }
> >
> > -  if (!FoundSection) {
> > +  if (!FoundSection && mOutImageType != FW_ACPI_IMAGE) {
> >      Error (NULL, 0, 3000, "Invalid", "Did not find any '.text' section.");
> >      assert (FALSE);
> >    }
> > diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c
> b/BaseTools/Source/C/GenFw/Elf64Convert.c
> > index 8fe672e98448..8b09db7b690b 100644
> > --- a/BaseTools/Source/C/GenFw/Elf64Convert.c
> > +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c
> > @@ -714,7 +714,7 @@ ScanSections64 (
> >      }
> >    }
> >
> > -  if (!FoundSection) {
> > +  if (!FoundSection && mOutImageType != FW_ACPI_IMAGE) {
> >      Error (NULL, 0, 3000, "Invalid", "Did not find any '.text' section.");
> >      assert (FALSE);
> >    }
> >





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76172): https://edk2.groups.io/g/devel/message/76172
Mute This Topic: https://groups.io/mt/83386371/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-