Reviewed-by: Jiewen Yao <jiewen....@intel.com> Hi Scottie Please remember to add Wang, Jian J as reviewer too.
Thank you Yao Jiewen > -----Original Message----- > From: Kuo, Scottie <scottie....@intel.com> > Sent: Monday, May 24, 2021 2:41 PM > To: devel@edk2.groups.io > Cc: Kuo, Scottie <scottie....@intel.com>; Zhang, Qi1 <qi1.zh...@intel.com>; > Kumar, Rahul1 <rahul1.ku...@intel.com>; Yao, Jiewen > <jiewen....@intel.com>; Chu, Maggie <maggie....@intel.com> > Subject: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize > SupportedAttributes > parameter. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3408 > > The value of SupportedAttributes in OpalGetSupportedAttributesInfo () > is left undetermined, if the caller doesn't initialize it. > Initialize it in the function entry. > > Signed-off-by: Scottie Kuo <scottie....@intel.com> > Cc: Qi Zhang <qi1.zh...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Maggie Chu <maggie....@intel.com> > --- > SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c > b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c > index b58597e61f..c840590e8e 100644 > --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c > +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c > @@ -1,7 +1,7 @@ > /** @file > Public API for Opal Core library. > > -Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2016 - 2021, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -1647,6 +1647,7 @@ OpalGetSupportedAttributesInfo( > NULL_CHECK(OpalBaseComId); > > ZeroMem(Buffer, BUFFER_SIZE); > + ZeroMem(SupportedAttributes, sizeof(OPAL_DISK_SUPPORT_ATTRIBUTE)); > ASSERT(sizeof(Buffer) >= sizeof(TCG_SUPPORTED_SECURITY_PROTOCOLS)); > > // > -- > 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75806): https://edk2.groups.io/g/devel/message/75806 Mute This Topic: https://groups.io/mt/83121358/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
