Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
> -----Original Message----- > From: mikub...@linux.microsoft.com <mikub...@linux.microsoft.com> > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; > Dong, Eric <eric.d...@intel.com> > Subject: [edk2-platforms][PATCH v2 30/35] MinPlatformPkg: Remove > SpiFlashCommonLibNull > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 > > The library instance has moved to IntelSiliconPkg. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Eric Dong <eric.d...@intel.com> > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > --- > > Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlashC > ommonLibNull.c | 101 -------------------- > > Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlashC > ommonLibNull.inf | 29 ------ > Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h > | 98 ------------------- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > | > 2 - > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > | > 4 - > 5 files changed, 234 deletions(-) > > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlas > hCommonLibNull.c > b/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlas > hCommonLibNull.c > deleted file mode 100644 > index 403b16a1b421..000000000000 > --- > a/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlas > hCommonLibNull.c > +++ /dev/null > @@ -1,101 +0,0 @@ > -/** @file > - Null Library instance of SPI Flash Common Library Class > - > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#include <Uefi.h> > -#include <Library/DebugLib.h> > - > -/** > - Enable block protection on the Serial Flash device. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashLock ( > - VOID > - ) > -{ > - return EFI_SUCCESS; > -} > - > -/** > - Read NumBytes bytes of data from the address specified by > - PAddress into Buffer. > - > - @param[in] Address The starting physical address of the read. > - @param[in,out] NumBytes On input, the number of bytes to read. On > output, the number > - of bytes actually read. > - @param[out] Buffer The destination data buffer for the read. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashRead ( > - IN UINTN Address, > - IN OUT UINT32 *NumBytes, > - OUT UINT8 *Buffer > - ) > -{ > - ASSERT(FALSE); > - return EFI_SUCCESS; > -} > - > -/** > - Write NumBytes bytes of data from Buffer to the address specified by > - PAddresss. > - > - @param[in] Address The starting physical address of the write. > - @param[in,out] NumBytes On input, the number of bytes to write. On > output, > - the actual number of bytes written. > - @param[in] Buffer The source data buffer for the write. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashWrite ( > - IN UINTN Address, > - IN OUT UINT32 *NumBytes, > - IN UINT8 *Buffer > - ) > -{ > - ASSERT(FALSE); > - return EFI_SUCCESS; > -} > - > -/** > - Erase the block starting at Address. > - > - @param[in] Address The starting physical address of the block to > be > erased. > - This library assume that caller garantee that > the PAddress > - is at the starting address of this block. > - @param[in] NumBytes On input, the number of bytes of the logical > block > to be erased. > - On output, the actual number of bytes erased. > - > - @retval EFI_SUCCESS. Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashBlockErase ( > - IN UINTN Address, > - IN UINTN *NumBytes > - ) > -{ > - ASSERT(FALSE); > - return EFI_SUCCESS; > -} > - > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlas > hCommonLibNull.inf > b/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlas > hCommonLibNull.inf > deleted file mode 100644 > index 75ef1cb921df..000000000000 > --- > a/Platform/Intel/MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlas > hCommonLibNull.inf > +++ /dev/null > @@ -1,29 +0,0 @@ > -### @file > -# NULL instance of Spi Flash Common Library Class -# -# Copyright (c) 2017, > Intel Corporation. All rights reserved.<BR> -# -# SPDX-License-Identifier: > BSD-2- > Clause-Patent -# -### > - > -[Defines] > - INF_VERSION = 0x00010017 > - BASE_NAME = SpiFlashCommonLibNull > - FILE_GUID = F35BBEE7-A681-443E-BB15-07AF9FABBDED > - VERSION_STRING = 1.0 > - MODULE_TYPE = BASE > - LIBRARY_CLASS = SpiFlashCommonLib > -# > -# The following information is for reference only and not required by the > build > tools. > -# > -# VALID_ARCHITECTURES = IA32 X64 > -# > - > -[LibraryClasses] > - > -[Packages] > - MdePkg/MdePkg.dec > - > -[Sources] > - SpiFlashCommonLibNull.c > diff --git > a/Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h > b/Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h > deleted file mode 100644 > index 0c5e72258c2d..000000000000 > --- a/Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h > +++ /dev/null > @@ -1,98 +0,0 @@ > -/** @file > - The header file includes the common header files, defines > - internal structure and functions used by SpiFlashCommonLib. > - > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef __SPI_FLASH_COMMON_LIB_H__ > -#define __SPI_FLASH_COMMON_LIB_H__ > - > -#include <Uefi.h> > -#include <Library/BaseLib.h> > -#include <Library/PcdLib.h> > -#include <Library/DebugLib.h> > -#include <Library/BaseMemoryLib.h> > -#include <Library/MemoryAllocationLib.h> -#include > <Library/UefiDriverEntryPoint.h> -#include > <Library/UefiBootServicesTableLib.h> > - > -#define SECTOR_SIZE_4KB 0x1000 // Common 4kBytes sector size > -/** > - Enable block protection on the Serial Flash device. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashLock ( > - VOID > - ); > - > -/** > - Read NumBytes bytes of data from the address specified by > - PAddress into Buffer. > - > - @param[in] Address The starting physical address of the read. > - @param[in,out] NumBytes On input, the number of bytes to read. On > output, the number > - of bytes actually read. > - @param[out] Buffer The destination data buffer for the read. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashRead ( > - IN UINTN Address, > - IN OUT UINT32 *NumBytes, > - OUT UINT8 *Buffer > - ); > - > -/** > - Write NumBytes bytes of data from Buffer to the address specified by > - PAddresss. > - > - @param[in] Address The starting physical address of the write. > - @param[in,out] NumBytes On input, the number of bytes to write. On > output, > - the actual number of bytes written. > - @param[in] Buffer The source data buffer for the write. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashWrite ( > - IN UINTN Address, > - IN OUT UINT32 *NumBytes, > - IN UINT8 *Buffer > - ); > - > -/** > - Erase the block starting at Address. > - > - @param[in] Address The starting physical address of the block to > be > erased. > - This library assume that caller garantee that > the PAddress > - is at the starting address of this block. > - @param[in] NumBytes On input, the number of bytes of the logical > block > to be erased. > - On output, the actual number of bytes erased. > - > - @retval EFI_SUCCESS. Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashBlockErase ( > - IN UINTN Address, > - IN UINTN *NumBytes > - ); > - > -#endif > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index 947431470a1f..8c6154099bf7 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -62,8 +62,6 @@ [LibraryClasses] > SiliconPolicyInitLib|Include/Library/SiliconPolicyInitLib.h > SiliconPolicyUpdateLib|Include/Library/SiliconPolicyUpdateLib.h > > - SpiFlashCommonLib|Include/Library/SpiFlashCommonLib.h > - > BoardInitLib|Include/Library/BoardInitLib.h > MultiBoardInitSupportLib|Include/Library/MultiBoardInitSupportLib.h > SecBoardInitLib|Include/Library/SecBoardInitLib.h > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 15867eee4e61..d58ed0ee7eae 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -109,7 +109,6 @@ [LibraryClasses.common.DXE_DRIVER] > > TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/TpmPlatformHierarchyLi > b/TpmPlatformHierarchyLib.inf > > [LibraryClasses.common.DXE_SMM_DRIVER] > - > SpiFlashCommonLib|MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/Spi > FlashCommonLibNull.inf > > TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP > ointCheckLib.inf > TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointLib.inf > > @@ -118,7 +117,6 @@ [LibraryClasses.common.MM_STANDALONE] > > MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAlloca > tionLib/StandaloneMmMemoryAllocationLib.inf > > MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/Standalo > neMmServicesTableLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > - > SpiFlashCommonLib|MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/Spi > FlashCommonLibNull.inf > > StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoin > t/StandaloneMmDriverEntryPoint.inf > > VariableReadLib|MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMm > VariableReadLib.inf > > VariableWriteLib|MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMm > VariableWriteLib.inf > @@ -159,8 +157,6 @@ [Components] > > > MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootM > anagerLib.inf > > - > MinPlatformPkg/Flash/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull. > inf > - > MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemoryConfig.inf > > MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrap > perHobProcessLib.inf > > MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWra > pperPlatformSecLib.inf > -- > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75371): https://edk2.groups.io/g/devel/message/75371 Mute This Topic: https://groups.io/mt/82929240/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
