Reviewed-by: Liming Gao <[email protected]> This fix is clear.
Thanks Liming > -----邮件原件----- > 发件人: [email protected] <[email protected]> 代表 Sergei > Dmitrouk > 发送时间: 2021年5月19日 0:10 > 收件人: [email protected] > 抄送: Ray Ni <[email protected]>; Zhichao Gao <[email protected]> > 主题: [edk2-devel] [PATCH v2 1/3] ShellPkg/HttpDynamicCommand: Fix > possible uninitialized use > > `Status` can be used uninitialized: > > /* Evaluates to FALSE */ > if (ShellGetExecutionBreakFlag ()) { > Status = EFI_ABORTED; > break; > } > > /* Evaluates to FALSE */ > if (!Context->ContentDownloaded && !Context->ResponseToken.Event) { > Status = ...; > ASSERT_EFI_ERROR (Status); > } else { > ResponseMessage.Data.Response = NULL; > } > > /* UNINITIALIZED USE */ > if (EFI_ERROR (Status)) { > break; > } > > Cc: Ray Ni <[email protected]> > Cc: Zhichao Gao <[email protected]> > Signed-off-by: Sergei Dmitrouk <[email protected]> > --- > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > b/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > index 3735a4a7e645..7b9b2d238015 100644 > --- a/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > +++ b/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > @@ -1524,6 +1524,7 @@ GetResponse ( > Context->ResponseToken.Message = &ResponseMessage; > Context->ContentLength = 0; > Context->Status = REQ_OK; > + Status = EFI_SUCCESS; > MsgParser = NULL; > ResponseData.StatusCode = HTTP_STATUS_UNSUPPORTED_STATUS; > ResponseMessage.Data.Response = &ResponseData; > -- > 2.17.6 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75297): https://edk2.groups.io/g/devel/message/75297 Mute This Topic: https://groups.io/mt/82926807/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
