Erdem: Laszlo is right. The rule is to align spec definition. Thanks Liming > -----邮件原件----- > 发件人: Laszlo Ersek <ler...@redhat.com> > 发送时间: 2021年5月19日 0:02 > 收件人: Erdem Aktas <erdemak...@google.com>; Brijesh Singh > <brijesh.si...@amd.com> > 抄送: devel@edk2.groups.io; James Bottomley <j...@linux.ibm.com>; Min > Xu <min.m...@intel.com>; Jiewen Yao <jiewen....@intel.com>; Tom > Lendacky <thomas.lenda...@amd.com>; Jordan Justen > <jordan.l.jus...@intel.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>; > Michael D Kinney <michael.d.kin...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Zhiguang Liu <zhiguang....@intel.com> > 主题: Re: [PATCH v2 04/13] MdePkg/Register/Amd: define GHCB macro for > Register GPA structure > > On 05/17/21 20:25, Erdem Aktas wrote: > > I verified that the values align with the GHCB spec publication: > > #56421 Revision: 2.00 > > > > Just one question: is there any reason why GHCB_* defines are decimal > > while the SVM_EXIT_* are all in hexadecimal? Does EDK2 have any > > preference? > > (I'm unaware of any preference in edk2 -- it's probably best to stick > with the base that the spec itself uses, but even using a different base > is not a huge deal, if the numbers in question are not large.) > > Thanks! > Laszlo > > > > > Reviewed-by: Erdem Aktas <erdemak...@google.com> > > > > -Erdem > > > > On Wed, May 12, 2021 at 4:46 PM Brijesh Singh <brijesh.si...@amd.com> > wrote: > >> > >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > >> > >> An SEV-SNP guest is required to perform the GHCB GPA registration. See > >> the GHCB specification for further details. > >> > >> Cc: James Bottomley <j...@linux.ibm.com> > >> Cc: Min Xu <min.m...@intel.com> > >> Cc: Jiewen Yao <jiewen....@intel.com> > >> Cc: Tom Lendacky <thomas.lenda...@amd.com> > >> Cc: Jordan Justen <jordan.l.jus...@intel.com> > >> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > >> Cc: Laszlo Ersek <ler...@redhat.com> > >> Cc: Erdem Aktas <erdemak...@google.com> > >> Cc: Michael D Kinney <michael.d.kin...@intel.com> > >> Cc: Liming Gao <gaolim...@byosoft.com.cn> > >> Cc: Zhiguang Liu <zhiguang....@intel.com> > >> Reviewed-by: Laszlo Ersek <ler...@redhat.com> > >> Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > >> Signed-off-by: Brijesh Singh <brijesh.si...@amd.com> > >> --- > >> MdePkg/Include/Register/Amd/Fam17Msr.h | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h > b/MdePkg/Include/Register/Amd/Fam17Msr.h > >> index cdb8f588ccf8..542e4cdf4782 100644 > >> --- a/MdePkg/Include/Register/Amd/Fam17Msr.h > >> +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h > >> @@ -53,6 +53,11 @@ typedef union { > >> UINT64 Features:52; > >> } GhcbHypervisorFeatures; > >> > >> + struct { > >> + UINT64 Function:12; > >> + UINT64 GuestFrameNumber:52; > >> + } GhcbGpaRegister; > >> + > >> VOID *Ghcb; > >> > >> UINT64 GhcbPhysicalAddress; > >> @@ -62,6 +67,8 @@ typedef union { > >> #define GHCB_INFO_SEV_INFO_GET 2 > >> #define GHCB_INFO_CPUID_REQUEST 4 > >> #define GHCB_INFO_CPUID_RESPONSE 5 > >> +#define GHCB_INFO_GHCB_GPA_REGISTER_REQUEST 18 > >> +#define GHCB_INFO_GHCB_GPA_REGISTER_RESPONSE 19 > >> #define GHCB_HYPERVISOR_FEATURES_REQUEST 128 > >> #define GHCB_HYPERVISOR_FEATURES_RESPONSE 129 > >> #define GHCB_INFO_TERMINATE_REQUEST 256 > >> -- > >> 2.17.1 > >> > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75296): https://edk2.groups.io/g/devel/message/75296 Mute This Topic: https://groups.io/mt/82926723/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
