Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 wenyi,xie via
> groups.io
> 发送时间: 2021年5月18日 15:17
> 收件人: devel@edk2.groups.io; jian.j.w...@intel.com; hao.a...@intel.com;
> dandan...@intel.com; eric.d...@intel.com
> 抄送: songdongku...@huawei.com; xiewen...@huawei.com
> 主题: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:
> remove dead code
>
> Outer condition is 'BlockData->Name==NULL' and inner
> condition is 'BlockData->Name!=NULL', Opposite 'if'
> condition leads to a dead code block.
>
> Cc: Jian J Wang <jian.j.w...@intel.com>
> Cc: Hao A Wu <hao.a...@intel.com>
> Cc: Dandan Bi <dandan...@intel.com>
> Cc: Eric Dong <eric.d...@intel.com>
> Signed-off-by: Wenyi Xie <xiewen...@huawei.com>
> ---
> MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index d492b769d51c..17a914208c6d 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2871,9 +2871,6 @@ ParseIfrData (
> //
> if ((BlockData->Name == NULL) && ((BlockData->Offset +
> BlockData->Width) > VarStorageData->Size)) {
> Status = EFI_INVALID_PARAMETER;
> - if (BlockData->Name != NULL) {
> - FreePool (BlockData->Name);
> - }
> FreePool (BlockData);
> goto Done;
> }
> --
> 2.20.1.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75292): https://edk2.groups.io/g/devel/message/75292
Mute This Topic: https://groups.io/mt/82926584/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
