On 5/14/21 2:54 PM, Lendacky, Thomas via groups.io wrote: > On 5/10/21 10:04 PM, gaoliming via groups.io wrote: >> Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > > Thanks, Liming. > > Sorry, for the delay, your email ended up in my Spam folder... urg, IT at > its best. Anyway... > > The patch is changing enough that I don't think I should add your > Reviewed-by: just yet. Look for a new version soon.
Ugh, I thought this was for AP reset stack... wrong patch. Disregard. Thanks, Tom > > Thanks, > Tom > >> >>> -----邮件原件----- >>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Lendacky, >>> Thomas >>> 发送时间: 2021年5月10日 22:25 >>> 收件人: devel@edk2.groups.io >>> 抄送: Brijesh Singh <brijesh.si...@amd.com>; Eric Dong >>> <eric.d...@intel.com>; Ray Ni <ray...@intel.com>; Laszlo Ersek >>> <ler...@redhat.com>; Rahul Kumar <rahul1.ku...@intel.com> >>> 主题: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Properly cast from PCD to >>> SEV-ES jump table pointer >>> >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3385&data=04%7C01%7Cthomas.lendacky%40amd.com%7C0587fecbb35842c6d81408d9171212b5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637566188656978758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=sdSuHzrY%2BTfhad8aLKLSHvnPnL91CqHxclfH5E07aAc%3D&reserved=0 >>> >>> A VS2012 build fails with a cast conversion warning when the SEV-ES work >>> area PCD is cast as a pointer to the SEV_ES_AP_JMP_FAR type. >>> >>> When casting from a PCD value to a pointer, the cast should first be done >>> to a UINTN and then to the pointer. Update the code to perform a cast to >>> a UINTN before casting to a pointer to the SEV_ES_AP_JMP_FAR type. >>> >>> Cc: Eric Dong <eric.d...@intel.com> >>> Cc: Ray Ni <ray...@intel.com> >>> Cc: Laszlo Ersek <ler...@redhat.com> >>> Cc: Rahul Kumar <rahul1.ku...@intel.com> >>> Signed-off-by: Tom Lendacky <thomas.lenda...@amd.com> >>> --- >>> UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c >>> b/UefiCpuPkg/Library/MpInitLib/MpLib.c >>> index 3d945972a025..dc2a54aa31e8 100644 >>> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c >>> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c >>> @@ -1265,7 +1265,7 @@ SetSevEsJumpTable ( >>> UINT32 Offset, InsnByte; >>> UINT8 LoNib, HiNib; >>> >>> - JmpFar = (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 >>> (PcdSevEsWorkAreaBase); >>> + JmpFar = (SEV_ES_AP_JMP_FAR *) (UINTN) FixedPcdGet32 >>> (PcdSevEsWorkAreaBase); >>> ASSERT (JmpFar != NULL); >>> >>> // >>> -- >>> 2.31.0 >>> >>> >>> >>> >>> >> >> >> >> >> >> >> >> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75133): https://edk2.groups.io/g/devel/message/75133 Mute This Topic: https://groups.io/mt/82738081/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
