On 04/13/21 02:59, gaoliming wrote: > Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Thanks, I've updated the email address in your existent R-b on the patch. Laszlo > >> -----邮件原件----- >> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Anthony >> PERARD via groups.io >> 发送时间: 2021年4月12日 21:30 >> 收件人: devel@edk2.groups.io >> 抄送: Laszlo Ersek <ler...@redhat.com>; Jordan Justen >> <jordan.l.jus...@intel.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>; >> xen-de...@lists.xenproject.org; Anthony PERARD >> <anthony.per...@citrix.com>; Julien Grall <jul...@xen.org>; Michael D >> Kinney <michael.d.kin...@intel.com>; Liming Gao >> <gaolim...@byosoft.com.cn>; Zhiguang Liu <zhiguang....@intel.com>; Liming >> Gao <liming....@intel.com> >> 主题: [edk2-devel] [PATCH v3 2/7] MdePkg: Allow PcdFSBClock to by >> Dynamic >> >> We are going to want to change the value of PcdFSBClock at run time in >> OvmfXen, so move it to the PcdsDynamic section. >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 >> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> >> Reviewed-by: Laszlo Ersek <ler...@redhat.com> >> Reviewed-by: Liming Gao <liming....@intel.com> >> --- >> >> Notes: >> CC: Michael D Kinney <michael.d.kin...@intel.com> >> CC: Liming Gao <gaolim...@byosoft.com.cn> >> CC: Zhiguang Liu <zhiguang....@intel.com> >> >> MdePkg/MdePkg.dec | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >> index f4156920e599..8965e903e093 100644 >> --- a/MdePkg/MdePkg.dec >> +++ b/MdePkg/MdePkg.dec >> @@ -2265,10 +2265,6 @@ [PcdsFixedAtBuild,PcdsPatchableInModule] >> # @ValidList 0x80000001 | 8, 16, 32 >> gEfiMdePkgTokenSpaceGuid.PcdPort80DataWidth|8|UINT8|0x0000002d >> >> - ## This value is used to configure X86 Processor FSB clock. >> - # @Prompt FSB Clock. >> - >> gEfiMdePkgTokenSpaceGuid.PcdFSBClock|200000000|UINT32|0x0000000c >> - >> ## The maximum printable number of characters. UefLib functions: >> AsciiPrint(), AsciiErrorPrint(), >> # PrintXY(), AsciiPrintXY(), Print(), ErrorPrint() base on this PCD > value to >> print characters. >> # @Prompt Maximum Printable Number of Characters. >> @@ -2372,5 +2368,9 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, >> PcdsDynamic, PcdsDynamicEx] >> # @Prompt Boot Timeout (s) >> >> gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|0xffff|UINT16|0x0000 >> 002c >> >> + ## This value is used to configure X86 Processor FSB clock. >> + # @Prompt FSB Clock. >> + >> gEfiMdePkgTokenSpaceGuid.PcdFSBClock|200000000|UINT32|0x0000000c >> + >> [UserExtensions.TianoCore."ExtraFiles"] >> MdePkgExtra.uni >> -- >> Anthony PERARD >> >> >> >> >> > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74028): https://edk2.groups.io/g/devel/message/74028 Mute This Topic: https://groups.io/mt/82054474/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-