Hi Tung Lun,
The fix looks good, but please help to re-send with correct patch format. Thanks, Chasel 1. remove Change-id 2. cc all reviewers/maintainers 3. add bugzilla link to describe the issue you are fixing. 4. enrich commit message to describe the fix. > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tung Lun > Sent: Friday, April 2, 2021 10:32 AM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun <tung.lun....@intel.com> > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix multibyte array data issue > > Change-Id: Iad50d68a93ea1da13c2264fac7229f2d540531f0 > Signed-off-by: Loo Tung Lun <tung.lun....@intel.com> > --- > IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py > b/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py > index cad9b60e73..5e94e86db5 100644 > --- a/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py > +++ b/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py > @@ -291,7 +291,6 @@ class CFspDsc2Yaml(): > raise Exception('DSC variable creation error !') > else: raise > Exception('Unsupported file "%s" !' % file_name)- > gen_cfg_data.UpdateDefaultValue() self.gen_cfg_data = gen_cfg_data > def print_dsc_line(self):-- > 2.28.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#73635): https://edk2.groups.io/g/devel/message/73635 > Mute This Topic: https://groups.io/mt/81794616/1777047 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.c...@intel.com] -=- > =-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73716): https://edk2.groups.io/g/devel/message/73716 Mute This Topic: https://groups.io/mt/81794616/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-