On 2021.04.03 17:15, Mario Bălănică wrote:
> -#if (RPI_MODEL == 4) > - Divisor = MmioRead32(BCM2836_CM_BASE + BCM2836_CM_VPU_CLOCK_DIVISOR) & 0xFFFFFF; > - if (Divisor != 0) > - BaseClockRate = (BaseClockRate << 12) / Divisor; > -#endifKeeping this doesn't interfere with the rest of the patch. I've removed it only because it's useless on the latest firmware.
Okay, then can you please send a v2 of your patch that leaves this in? I believe this divisor arithmetic is still needed with older versions of start4.elf, and we may have people using choosing to use an older start4.elf for whatever reason.
In general, if it doesn't interfere with your proposal, it's better to leave existing code in, as overzealous code removal may have unintended consequences, unless you are confident that the code is superfluous.
Also make sure you update the commit message to mention what issue you are fixing.
Thanks, /Pete -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73671): https://edk2.groups.io/g/devel/message/73671 Mute This Topic: https://groups.io/mt/81808942/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
