Hi Sami Mujawar, Thanks for catching that. I will add them.
Thanks, Dandan From: [email protected] <[email protected]> On Behalf Of Sami Mujawar Sent: Wednesday, March 31, 2021 12:48 AM To: Bi, Dandan <[email protected]>; [email protected] Subject: Re: [edk2-devel] [patch V4 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access Hi Dandan, On Sun, Mar 28, 2021 at 05:03 AM, Dandan Bi wrote: + Flag = FilterBeforeMmIoRead (FilterWidth8, Address, &Value); + if (Flag { There is a missing closing bracket here and at other places in MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c. Can you check, please? + Value = *(volatile UINT8*)Address; + } Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73553): https://edk2.groups.io/g/devel/message/73553 Mute This Topic: https://groups.io/mt/81670709/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
