Hi Dandan, This patch looks good to me.
Reviewed-by: Sami Mujawar <sami.muja...@arm.com> Regards, Sami Mujawar -----Original Message----- From: Dandan Bi <dandan...@intel.com> Sent: 28 March 2021 01:02 PM To: devel@edk2.groups.io Cc: Sami Mujawar <sami.muja...@arm.com>; Alexei Fedorov <alexei.fedo...@arm.com> Subject: [patch V4 07/29] DynamicTablesPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for RegisterFilterLibNull which will be consumed by IoLib and BaseLib. Cc: Sami Mujawar <sami.muja...@arm.com> Cc: Alexei Fedorov <alexei.fedo...@arm.com> Signed-off-by: Dandan Bi <dandan...@intel.com> Acked-by: Ard Biesheuvel <a...@kernel.org> --- DynamicTablesPkg/DynamicTablesPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc index 0232bda459..33b2a84c9d 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -18,10 +18,12 @@ [Defines] BUILD_TARGETS = DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER = DEFAULT !include DynamicTables.dsc.inc +!include MdePkg/MdeLibs.dsc.inc + [LibraryClasses] BaseLib|MdePkg/Library/BaseLib/BaseLib.inf BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73539): https://edk2.groups.io/g/devel/message/73539 Mute This Topic: https://groups.io/mt/81670685/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-