Hi Dandan, Another example of adsc.inc including a dsc.in from another package.
I recommend this patch be dropped. Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dandan Bi > Sent: Friday, March 26, 2021 1:39 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm <l...@nuviainc.com>; Meenakshi Aggarwal > <meenakshi.aggar...@nxp.com> > Subject: [edk2-devel] [edk2-platforms] [patch V3 31/35] Silicon/NXP: Consume > MdeLibs.dsc.inc for RegisterFilterLib > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > MdeLibs.dsc.inc was added for some basic/default library > instances provided by MdePkg and RegisterFilterLibNull Library > was also added into it as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for > RegisterFilterLibNull which will be consumed by IoLib and BaseLib. > > Cc: Leif Lindholm <l...@nuviainc.com> > Cc: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > V3: > Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common > [LibraryClasses] section since we can specify different [LibraryClasses] > section for libary instances in MdeLibs.dsc.inc. > --- > Silicon/NXP/NxpQoriqLs.dsc.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc > index 99a317aba7..2535a70035 100644 > --- a/Silicon/NXP/NxpQoriqLs.dsc.inc > +++ b/Silicon/NXP/NxpQoriqLs.dsc.inc > @@ -20,10 +20,12 @@ [Defines] > DSC_SPECIFICATION = 0x0001001A > SUPPORTED_ARCHITECTURES = AARCH64 > BUILD_TARGETS = DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER = DEFAULT > > +!include MdePkg/MdeLibs.dsc.inc > + > [LibraryClasses.common] > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf > -- > 2.18.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73398): https://edk2.groups.io/g/devel/message/73398 Mute This Topic: https://groups.io/mt/81623464/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-