You can push with the correction and add my R-B. No need to send V5 if there is no more comment for your patch set.
Thanks, Zhichao > -----Original Message----- > From: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com> > Sent: Thursday, March 25, 2021 7:36 PM > To: Gao, Zhichao <zhichao....@intel.com>; devel@edk2.groups.io > Cc: Ni, Ray <ray...@intel.com>; Wang, Nickle (HPS SW) > <nickle.w...@hpe.com>; O'Hanley, Peter (EXL) <peter.ohan...@hpe.com>; > Liming Gao <gaolim...@byosoft.com.cn> > Subject: RE: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > Redfish protocols > > Hi Zhichao, > I resend v4 patch, in which your R-B to the previous patch is removed and > Liming is added to CC list. No others changes were made in this patches. > I will send v5 with the correction on copyright. Or can I just push to master > with the correction and your R-B? > > Thanks > Abner > > > -----Original Message----- > > From: Gao, Zhichao [mailto:zhichao....@intel.com] > > Sent: Thursday, March 25, 2021 5:09 PM > > To: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; > > devel@edk2.groups.io > > Cc: Ni, Ray <ray...@intel.com>; Wang, Nickle (HPS SW) > > <nickle.w...@hpe.com>; O'Hanley, Peter (EXL) > <peter.ohan...@hpe.com>; > > Liming Gao <gaolim...@byosoft.com.cn> > > Subject: RE: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > > Redfish protocols > > > > First, thanks Liming's catch. > > > > Abner, > > > > The patch has been updated, you should remove my R-B for the V4 version. > > Otherwise the reviewers/maintainers may treated it as reviewed one. > > And please add the one who already gave the comment for your patch to > > the Cc list. They care about the about the change and this would help > > them to know the update and have a chance to view your patch in an early > time. > > > > For this patch, the copyright should be updated to 2021. With this > > updated, > > Reviewed-by: Zhichao Gao <zhichao....@intel.com> > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: Abner Chang <abner.ch...@hpe.com> > > > Sent: Thursday, March 25, 2021 12:53 PM > > > To: devel@edk2.groups.io > > > Cc: Ni, Ray <ray...@intel.com>; Gao, Zhichao > > > <zhichao....@intel.com>; Nickle Wang <nickle.w...@hpe.com>; Peter > > > O'Hanley <peter.ohan...@hpe.com> > > > Subject: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > > Redfish > > > protocols > > > > > > Add handle parsing for EFI Redfish Discover protocol. > > > Add handle parsing for EFI RestEx protocol. > > > > > > Signed-off-by: Abner Chang <abner.ch...@hpe.com> > > > Cc: Ray Ni <ray...@intel.com> > > > Cc: Zhichao Gao <zhichao....@intel.com> > > > Cc: Nickle Wang <nickle.w...@hpe.com> > > > Cc: Peter O'Hanley <peter.ohan...@hpe.com> > > > Reviewed-by: Zhichao Gao <zhichao....@intel.com> > > > --- > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++- > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 8 +++++++- > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++- > > > 3 files changed, 13 insertions(+), 3 deletions(-) > > > > > > diff --git > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > index 93b69cd8e9..446cd8d609 100644 > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > @@ -2,7 +2,7 @@ > > > # Provides interface to advanced shell functionality for parsing > > > both > > handle > > > and protocol database. > > > # Copyright (c) 2010 - 2018, Intel Corporation. All rights > > > reserved. <BR> # > > (C) > > > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> - > # > > > (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> > > > +# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > > +LP<BR> > > > # > > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -269,6 +269,8 > @@ > > > gEfiHttpProtocolGuid ## UNDEFINED > > > gEfiHttpUtilitiesProtocolGuid ## UNDEFINED > > > gEfiRestProtocolGuid ## UNDEFINED > > > + gEfiRestExProtocolGuid ## UNDEFINED > > > + gEfiRedfishDiscoverProtocolGuid ## UNDEFINED > > > gEfiMmEndOfDxeProtocolGuid ## UNDEFINED > > > gEfiMmIoTrapDispatchProtocolGuid ## UNDEFINED > > > gEfiMmPowerButtonDispatchProtocolGuid ## UNDEFINED > > > diff --git > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > index 500a95a89a..e34cefd7b4 100644 > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > @@ -3,7 +3,7 @@ > > > > > > Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR> > > > (C) Copyright 2013-2015 Hewlett-Packard Development Company, > > L.P.<BR> > > > - (C) Copyright 2015-2016 Hewlett Packard Enterprise Development > > LP<BR> > > > + (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > LP<BR> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > **/ > > > @@ -2250,6 +2250,12 @@ STATIC CONST GUID_INFO_BLOCK > > > mGuidStringList[] = { > > > {STRING_TOKEN(STR_PARTITION_INFO), > > > &gEfiPartitionInfoProtocolGuid, > > > PartitionInfoProtocolDumpInformation}, > > > {STRING_TOKEN(STR_HII_POPUP), &gEfiHiiPopupProtocolGuid, > > > NULL}, > > > > > > +// > > > +// UEFI 2.8 > > > +// > > > + {STRING_TOKEN(STR_REST_EX), &gEfiRestExProtocolGuid, > > > NULL}, > > > + {STRING_TOKEN(STR_REDFISH_DISCOVER), > > > &gEfiRedfishDiscoverProtocolGuid, NULL}, > > > + > > > // > > > // PI Spec ones > > > // > > > diff --git > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > index 9c8028d0d5..69fcbdfe0e 100644 > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > @@ -2,7 +2,7 @@ > > > // > > > // Copyright (c) 2010 - 2017, Intel Corporation. All rights > > > reserved. <BR> // > > (C) > > > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> > > > -// > > > (C) Copyright 2015-2016 Hewlett Packard Enterprise Development > > > LP<BR> > > > +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > > +LP<BR> > > > // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > > > @@ -308,6 +308,8 @@ > > > #string STR_NET_HTTP #language en-US "Http" > > > #string STR_NET_HTTP_U #language en-US "HttpUtilities" > > > #string STR_REST #language en-US "Rest" > > > +#string STR_REST_EX #language en-US "RestEx" > > > +#string STR_REDFISH_DISCOVER #language en-US "RedfishDiscover" > > > > > > #string STR_MM_EOD #language en-US "MmEndOfDxe" > > > #string STR_MM_ITD #language en-US "MmIoTrapDispatch" > > > -- > > > 2.17.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73303): https://edk2.groups.io/g/devel/message/73303 Mute This Topic: https://groups.io/mt/81595966/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
