We can remove the indent (as Laszlo mentioned) to make all changes in consistent. All other changes on RISC-V are the same. Thanks
Reviewed-by: Abner Chang <abner.ch...@hpe.com> > -----Original Message----- > From: Dandan Bi [mailto:dandan...@intel.com] > Sent: Monday, March 22, 2021 4:20 PM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; > Schaefer, Daniel <daniel.schae...@hpe.com>; Chen, Gilbert > <gilbert.c...@hpe.com> > Subject: [edk2-platforms] [patch V2 20/35] Platform/RISC-V: Consume > MdeLibs.dsc.inc for RegisterFilterLib > > REF: INVALID URI REMOVED > 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid- > 3D3246&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulks > kz6qU3NYRO03nHp9P7Z5q59A3E&m=Us0bEx6- > rMuxeAV21PFz3igajFEdNSWCnZ3L5n-wUv8&s=O-PHg5t3PRykzhU- > mwLPjR5EyFarY4iRfUiz8oBOxjo&e= > > MdeLibs.dsc.inc was added for some basic/default library > instances provided by MdePkg and RegisterFilterLibNull Library > was also added into it as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for > RegisterFilterLibNull which will be consumed by IoLib and BaseLib. > > Cc: Abner Chang <abner.ch...@hpe.com> > Cc: Daniel Schaefer <daniel.schae...@hpe.com> > Cc: Gilbert Chen <gilbert.c...@hpe.com> > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc > b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc > index 092717d2ef..78a737317f 100644 > --- a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc > +++ b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc > @@ -35,10 +35,12 @@ [BuildOptions] > > ########################################################## > ###################### > [SkuIds] > 0|DEFAULT > > [LibraryClasses.common] > + !include MdePkg/MdeLibs.dsc.inc > + > RiscVOpensbiPlatformLib|Platform/RISC- > V/PlatformPkg/Library/OpensbiPlatformLibNull/OpensbiPlatformLibNull.inf > RiscVCpuLib|Silicon/RISC- > V/ProcessorPkg/Library/RiscVCpuLib/RiscVCpuLib.inf > RiscVEdk2SbiLib|Silicon/RISC- > V/ProcessorPkg/Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.inf > RiscVOpensbiLib|Silicon/RISC- > V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73160): https://edk2.groups.io/g/devel/message/73160 Mute This Topic: https://groups.io/mt/81542421/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
