Kun: Acked-by: means the maintainer agrees this change, but no time for detail code review. Based on current develop process, with Acked-by, the patch can also be merged.
Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin > 发送时间: 2021年3月19日 2:26 > 收件人: Ard Biesheuvel <a...@kernel.org> > 抄送: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianoc...@kernel.org>; > Leif Lindholm <l...@nuviainc.com> > 主题: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: > DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe > > Hi Ard, > > Thanks for providing the tag. For my own learning purpose, could you > please let me know how I can get a "reviewed-by" tag for this change? > Should I add more reviewers than package maintainers listed on > "Maintainers.txt"? > > Thanks for the help. > > Regards, > Kun > > On 03/18/2021 11:14, Ard Biesheuvel wrote: > > On Thu, 18 Mar 2021 at 19:07, Kun Qin <kuqi...@gmail.com> wrote: > >> > >> Hi Ard/Leif, > >> > >> Could you please review the change and let me know if you have any > >> feedback when there is chance? I can drop the patch if this package is > >> not supported/maintained any more. Please let me know how you would > like > >> to proceed. > >> > >> Thanks in advance. > >> > >> Regards, > >> Kun > >> > >> On 03/16/2021 11:10, Kun Qin via groups.io wrote: > >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 > >>> > >>> This change added NULL MmUnblockMemoryLib instance in > DeveloperBox.dsc to > >>> resolve new dependency by VariableSmmRuntimeDxe. The library > interface > >>> is consumed by variable module to better support variable runtime cache > >>> feature. > >>> > >>> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > >>> Cc: Leif Lindholm <l...@nuviainc.com> > >>> > >>> Signed-off-by: Kun Qin <kuqi...@gmail.com> > > > > Acked-by: Ard Biesheuvel <a...@kernel.org> > > > >>> --- > >>> > >>> Notes: > >>> v2: > >>> - No review, no change. > >>> > >>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >>> index 0a11b796cca5..acaa4cd90fc5 100644 > >>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >>> @@ -49,6 +49,8 @@ [LibraryClasses] > >>> > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tpm > MeasurementLibNull.inf > >>> !endif > >>> > >>> + > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnbloc > kMemoryLibNull.inf > >>> + > >>> [LibraryClasses.common.SEC] > >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > >>> > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > >>> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73030): https://edk2.groups.io/g/devel/message/73030 Mute This Topic: https://groups.io/mt/81445829/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
