> (1) I think "mGdtTemplate" would be a better name than "gGdtTemplate". I > think the "g" prefix is used when an object is identical for all > firmware modules (such as named GUIDs, for example). Agree! I will change in v2.
> > (2) I think the last hunk does not belong in this patch -- more > precisely, I *disagree* with the last hunk. Inserting a space in the > middle of a typecast, after the parenthesized typename, is a bad > practice in edk2; it is error prone and suggests that typecasts have low > binding power (when in reality they have almost the strongest binding). I double checked the edk2 coding standard and did find a rule for this. That might be just my personal preference. Since I need your Ack or Rb, I will remove this change in v2. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72943): https://edk2.groups.io/g/devel/message/72943 Mute This Topic: https://groups.io/mt/81368664/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
