From: Isaac Oram <isaac.w.o...@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242

Adds IPMI Transport Protocol/PPI to the
IpmiInit PEIM and DXE driver's DEPEXs

Cc: Sai Chaganty <rangasai.v.chaga...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Michael Kubacki <michael.kuba...@microsoft.com>
Signed-off-by: Isaac Oram <isaac.w.o...@intel.com>
Co-authored-by: Nate DeSimone <nathaniel.l.desim...@intel.com>
---
 .../IpmiFeaturePkg/IpmiInit/DxeIpmiInit.c                   | 4 ++--
 .../IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf                 | 6 +++---
 .../IpmiFeaturePkg/IpmiInit/PeiIpmiInit.c                   | 4 ++--
 .../IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf                 | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.c 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.c
index 0639c3b2a1..baa2f1bb9f 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.c
@@ -1,7 +1,7 @@
 /** @file
     IPMI stack initialization.
 
-Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -79,7 +79,7 @@ Returns:
 
   //
   // Set up a loop to retry for up to 30 seconds. Calculate retries not timeout
-  // so that in case KCS is not enabled and EfiIpmiSendCommand() returns
+  // so that in case KCS is not enabled and IpmiSendCommand() returns
   // immediately we will not wait all the 30 seconds.
   //
   Retries = BMC_TIMEOUT / BMC_KCS_TIMEOUT + 1;
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf
index 68ff70cd43..831bfb0b5e 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf
@@ -1,7 +1,7 @@
 ### @file
 # Component description file for IPMI initialization.
 #
-# Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -10,7 +10,7 @@
 [Defines]
   INF_VERSION                    = 0x00010005
   BASE_NAME                      = DxeIpmiInit
-  FILE_GUID                      = 07A01ACF-46D5-48de-A63D-74FA92AA8450
+  FILE_GUID                      = 09D958D8-4646-886D-85F1-AA9249CC50FB
   MODULE_TYPE                    = DXE_DRIVER
   VERSION_STRING                 = 1.0
   ENTRY_POINT                    = IpmiInterfaceInit
@@ -31,4 +31,4 @@
   TimerLib
 
 [Depex]
-  TRUE
+  gIpmiTransportProtocolGuid
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.c 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.c
index 062d20c44e..e4d040c381 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.c
@@ -1,7 +1,7 @@
 /** @file
   IPMI stack initialization in PEI.
 
-Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -38,7 +38,7 @@ Returns:
 
   //
   // Set up a loop to retry for up to 30 seconds. Calculate retries not timeout
-  // so that in case KCS is not enabled and EfiIpmiSendCommand() returns
+  // so that in case KCS is not enabled and IpmiSendCommand() returns
   // immediately we will not wait all the 30 seconds.
   //
   Retries = BMC_TIMEOUT_PEI/ BMC_KCS_TIMEOUT + 1;
diff --git 
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf 
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf
index 825451ede1..607a185eb6 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf
@@ -1,7 +1,7 @@
 ### @file
 # Component description file for IPMI initialization in PEI.
 #
-# Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -29,4 +29,4 @@
   IpmiCommandLib
 
 [Depex]
-  TRUE
+  gPeiIpmiTransportPpiGuid
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72311): https://edk2.groups.io/g/devel/message/72311
Mute This Topic: https://groups.io/mt/81016653/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to