From: Pierre Gondois <pierre.gond...@arm.com> This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois <pierre.gond...@arm.com> Reviewed-by: Sami Mujawar <sami.muja...@arm.com> --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3 .../ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h | 4 ++-- .../Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c | 12 ++++++------ .../Include/Protocol/ArmScmiPerformanceProtocol.h | 14 +++++++------- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h index b274b5ab2ad4..b178aa3fdf10 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2021, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -22,7 +22,7 @@ #define NUM_REMAIN_PERF_LEVELS_SHIFT 16 #define NUM_REMAIN_PERF_LEVELS(Lvls) (Lvls >> NUM_REMAIN_PERF_LEVELS_SHIFT) -/** Return values for SCMI_MESSAGE_ID_PERFORMANCE_DESCRIBE_LEVELS command. +/** Return values for ScmiMessageIdPerformanceDescribeLevels command. SCMI Spec section 4.5.2.5 **/ typedef struct { diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c index 51cad4d2c602..684ed713d52c 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c @@ -108,7 +108,7 @@ PerformanceDomainAttributes ( *MessageParams = DomainId; Cmd.ProtocolId = ScmiProtocolIdPerformance; - Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_DOMAIN_ATTRIBUTES; + Cmd.MessageId = ScmiMessageIdPerformanceDomainAttributes; PayloadLength = sizeof (DomainId); @@ -180,7 +180,7 @@ PerformanceDescribeLevels ( *MessageParams++ = DomainId; Cmd.ProtocolId = ScmiProtocolIdPerformance; - Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_DESCRIBE_LEVELS; + Cmd.MessageId = ScmiMessageIdPerformanceDescribeLevels; do { @@ -259,7 +259,7 @@ PerformanceLimitsSet ( *MessageParams = Limits->RangeMin; Cmd.ProtocolId = ScmiProtocolIdPerformance; - Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_LIMITS_SET; + Cmd.MessageId = ScmiMessageIdPerformanceLimitsSet; PayloadLength = sizeof (DomainId) + sizeof (SCMI_PERFORMANCE_LIMITS); @@ -305,7 +305,7 @@ PerformanceLimitsGet ( *MessageParams = DomainId; Cmd.ProtocolId = ScmiProtocolIdPerformance; - Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_LIMITS_GET; + Cmd.MessageId = ScmiMessageIdPerformanceLimitsGet; PayloadLength = sizeof (DomainId); @@ -355,7 +355,7 @@ PerformanceLevelSet ( *MessageParams = Level; Cmd.ProtocolId = ScmiProtocolIdPerformance; - Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_LEVEL_SET; + Cmd.MessageId = ScmiMessageIdPerformanceLevelSet; PayloadLength = sizeof (DomainId) + sizeof (Level); @@ -400,7 +400,7 @@ PerformanceLevelGet ( *MessageParams = DomainId; Cmd.ProtocolId = ScmiProtocolIdPerformance; - Cmd.MessageId = SCMI_MESSAGE_ID_PERFORMANCE_LEVEL_GET; + Cmd.MessageId = ScmiMessageIdPerformanceLevelGet; PayloadLength = sizeof (DomainId); diff --git a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h index 96a4d66737bd..8c70aa75281e 100644 --- a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2021, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -247,12 +247,12 @@ typedef struct _SCMI_PERFORMANCE_PROTOCOL { } SCMI_PERFORMANCE_PROTOCOL; typedef enum { - SCMI_MESSAGE_ID_PERFORMANCE_DOMAIN_ATTRIBUTES = 0x3, - SCMI_MESSAGE_ID_PERFORMANCE_DESCRIBE_LEVELS = 0x4, - SCMI_MESSAGE_ID_PERFORMANCE_LIMITS_SET = 0x5, - SCMI_MESSAGE_ID_PERFORMANCE_LIMITS_GET = 0x6, - SCMI_MESSAGE_ID_PERFORMANCE_LEVEL_SET = 0x7, - SCMI_MESSAGE_ID_PERFORMANCE_LEVEL_GET = 0x8, + ScmiMessageIdPerformanceDomainAttributes = 0x3, + ScmiMessageIdPerformanceDescribeLevels = 0x4, + ScmiMessageIdPerformanceLimitsSet = 0x5, + ScmiMessageIdPerformanceLimitsGet = 0x6, + ScmiMessageIdPerformanceLevelSet = 0x7, + ScmiMessageIdPerformanceLevelGet = 0x8, } SCMI_MESSAGE_ID_PERFORMANCE; #endif /* ARM_SCMI_PERFORMANCE_PROTOCOL_H_ */ -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72080): https://edk2.groups.io/g/devel/message/72080 Mute This Topic: https://groups.io/mt/80850106/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
