Good note. Is there an easy way to resubmit? Just edit the patch as is, or does there need to be a v2?
On Fri, Feb 19, 2021 at 6:30 AM Laszlo Ersek <ler...@redhat.com> wrote: > On 02/18/21 05:07, Bret Barkelew wrote: > > I'm not opposed to moving to 2.15.03 for consistency, but we'll have to > > publish a new package. This one is already pushed to Nuget. > > Thanks for the answers. From Liming's answer, I understand we don't try > to keep CI strictly in sync with edk2's (internal) BaseTools. > > So the patch should be fine; however, I think the subject line could be > clarified. "BaseTools: Update the NASM dependency" doesn't make it clear > that the CI builds are targeted primarily. > > Thanks > Laszlo > > > > > On Wed, Feb 17, 2021 at 7:39 PM gaoliming <gaolim...@byosoft.com.cn> > wrote: > > > >> Laszlo: > >> > >>> -----邮件原件----- > >>> 发件人: bounce+27952+71686+4905953+8761...@groups.io > >>> <bounce+27952+71686+4905953+8761...@groups.io> 代表 Laszlo Ersek > >>> 发送时间: 2021年2月16日 5:00 > >>> 收件人: devel@edk2.groups.io; b...@corthon.com > >>> 主题: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM > >>> dependency > >>> > >>> Hi Bret, > >>> > >>> On 02/12/21 21:49, Bret Barkelew wrote: > >>>> This is primarily used by CI builds, but may also be used by > platforms. > >>>> > >>>> Update NASM to support newer structures and features, as agreed in > >> recent > >>>> community meetings: > >>>> https://edk2.groups.io/g/devel/message/71289 > >>>> --- > >>>> BaseTools/Bin/nasm_ext_dep.yaml | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml > >>> b/BaseTools/Bin/nasm_ext_dep.yaml > >>>> index 60b1f71b56aa..56703d4c18e7 100644 > >>>> --- a/BaseTools/Bin/nasm_ext_dep.yaml > >>>> +++ b/BaseTools/Bin/nasm_ext_dep.yaml > >>>> @@ -13,6 +13,6 @@ > >>>> "type": "nuget", > >>>> "name": "mu_nasm", > >>>> "source": "https://api.nuget.org/v3/index.json";, > >>>> - "version": "2.14.02", > >>>> + "version": "2.15.5", > >>>> "flags": ["set_path", "host_specific"] > >>>> } > >>>> > >>> > >>> (1) I'm confused by the "patchlevel" number being "5" and not "05", in > >>> the "2.15.5" version. Per > >>> <https://edk2.groups.io/g/devel/message/71045>, my understanding has > >>> been that the latest release is "2.15.05". > >>> > >>> (2) The minimum required version, according to > >>> <https://edk2.groups.io/g/devel/message/71070>, is "2.15.01". In the > >>> RHEL build environments that matter to me, I can satisfy a NASM > >>> dependency up to 2.15.03, at this time, but not beyond. And this > matters > >>> because... > >>> > >> I understand CI environment tries to use the latest tool version for > >> verification. > >> > >>> (3) ... arguably, the NASM requirement in > >>> "BaseTools/Conf/tools_def.template" should be updated too, in the same > >>> patch: > >>> > >>> # - NASM 2.10 or later for use with the GCC toolchain family > >>> # - NASM 2.12.01 or later for use with all other toolchain families > >>> > >> This is edk2 build environment requirement. It will be updated when the > >> source code change is added. > >> > >> Thanks > >> Liming > >>> Thanks > >>> Laszlo > >>> > >>> > >>> > >>> > >>> > >> > >> > >> > >> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71849): https://edk2.groups.io/g/devel/message/71849 Mute This Topic: https://groups.io/mt/80722446/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
