On Wed, Jan 27, 2021 at 12:21 PM Vikas Singh
<vikas.si...@puresoftware.com> wrote:
>
> On Tue, Jan 26, 2021 at 4:49 PM Leif Lindholm <l...@nuviainc.com> wrote:
> >
> > Hi Vikas,
> >
> > On Tue, Jan 19, 2021 at 10:11:43 +0530, Vikas Singh wrote:
> > > > > > > +/** A helper macro for returning configuration manager objects
> > > > > > > +*/
> > > > > > > +#define HANDLE_CM_OBJECT(ObjId, CmObjectId, Object, ObjectCount)
> > > > > > > \
> > > > > > > + case ObjId: {
> > > > > > > \
> > > > > > > + CmObject->ObjectId = CmObjectId;
> > > > > > > \
> > > > > > > + CmObject->Size = sizeof (Object);
> > > > > > > \
> > > > > > > + CmObject->Data = (VOID*)&Object;
> > > > > > > \
> > > > > > > + CmObject->Count = ObjectCount;
> > > > > > > \
> > > > > > > + DEBUG ((
> > > > > > > \
> > > > > > > + DEBUG_INFO,
> > > > > > > \
> > > > > > > + #CmObjectId ": Ptr = 0x%p, Size = %d, Count = %d\n",
> > > > > > > \
> > > > > > > + CmObject->Data,
> > > > > > > \
> > > > > > > + CmObject->Size,
> > > > > > > \
> > > > > > > + CmObject->Count
> > > > > > > \
> > > > > > > + ));
> > > > > > > \
> > > > > > > + break;
> > > > > > > \
> > > > > > > + }
> > > > > >
> > > > > > This is code obfuscation. Please don't invent your own programming
> > > > > > languages. In C, the case, the start bracket, the break and the end
> > > > > > bracket always go inline.
> > > > > > The rest would be better as a static helper function than a macro.
> > > > > >
> > > > > Leif, changes are in accordance with :
> > > > > https://raw.githubusercontent.com/tianocore-docs/Docs/master/Specifications/CCS_2_1_Draft.pdf
> > > >
> > > > Do you mean 5.5.2.1:
> > > > Functional macros are generally discouraged.
> > > > ?
> > >
> > > Leif + Sami, I was referring section 5.7.3.7, since you commented on
> > > switch case & break statement.
> > > However keeping section 5.5.2.1 in consideration, I have done few
> > > changes and shared updated V1 series.
> > > Could you please have a look on it and revert, if in case you have any
> > > concerns.
> >
> > I have not seen any update?
> >
> > Please have a look at Sami's updates to the ARM platform code, which I
> > merged yeaterday.
> >
> > Best Regards,
> >
> > Leif
> >
> Leif , I have sent an updated V2 patch series today. FYI.
>
> Thnx.
Hi Leif,
Any Update on V2 patch series that I have shared to you at the end of Jan 2021.
I did not receive any comments (if any).
Thnx !!
Vikas Singh
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71569): https://edk2.groups.io/g/devel/message/71569
Mute This Topic: https://groups.io/mt/79415929/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
