Hi Michael, Thank you for this patch.
There must be something missing with the GCC5 settings for AARCH64 as this problem does not get flagged. However, this change looks good to me. Reviewed-by: Sami Mujawar <sami.muja...@arm.com> Regards, Sami Mujawar -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of mikuback via groups.io Sent: 03 February 2021 03:52 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel <ard.biesheu...@arm.com>; Sami Mujawar <sami.muja...@arm.com>; Jiewen Yao <jiewen....@intel.com>; Supreeth Venkatesh <supreeth.venkat...@arm.com> Subject: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection() From: Michael Kubacki <michael.kuba...@microsoft.com> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3203 The EFIAPI modifier is present in the function definition in FvLib.c but missing in FvLib.h. Causes a GCC build error. Cc: Ard Biesheuvel <ard.biesheu...@arm.com> Cc: Sami Mujawar <sami.muja...@arm.com> Cc: Jiewen Yao <jiewen....@intel.com> Cc: Supreeth Venkatesh <supreeth.venkat...@arm.com> Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> --- StandaloneMmPkg/Include/Library/FvLib.h | 1 + 1 file changed, 1 insertion(+) diff --git a/StandaloneMmPkg/Include/Library/FvLib.h b/StandaloneMmPkg/Include/Library/FvLib.h index c08e043cf65f..4ef2c8540a1f 100644 --- a/StandaloneMmPkg/Include/Library/FvLib.h +++ b/StandaloneMmPkg/Include/Library/FvLib.h @@ -50,6 +50,7 @@ FfsFindNextFile ( @retval EFI_SUCCESS **/ EFI_STATUS +EFIAPI FfsFindSection ( IN EFI_SECTION_TYPE SectionType, IN EFI_FFS_FILE_HEADER *FfsFileHeader, -- 2.28.0.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71088): https://edk2.groups.io/g/devel/message/71088 Mute This Topic: https://groups.io/mt/80346397/1779659 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [sami.muja...@arm.com] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71538): https://edk2.groups.io/g/devel/message/71538 Mute This Topic: https://groups.io/mt/80346397/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
