Personal github PR: https://github.com/tianocore/edk2/pull/1411
On 2/7/21 5:52 PM, Rebecca Cran wrote:
Much of the data for the SMBIOS tables is generic, and need not be duplicated for each platform. This patch series introduces ArmPkg/Universal/Smbios, which is largely copied from edk2-platforms/Silicon/HiSilicon/Drivers/Smbios and generates SMBIOS tables 0,1,2,3,4,7,13,32 and uses a combination of PCDs and calls into a new OemMiscLib to get information which varies between platforms. I plan to submit a patch against SbsaQemu to update it to use this new functionality. Changes from v7 to v8: o Changed associativity function to return 1-based value. o Changed cache level parameter and return values to be 1-based. o Other changes based on Leif's review feedback. More changes are needed to support reporting boot status etc., but with the series getting rather large I think it might be good to get this committed and make a follow-up series with the additional changes. Testing: o Ran Ecc tool o Ran smbiosview in the UEFI Shell Rebecca Cran (21): ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h MdePkg: Update IndustryStandard/SmBios.h with processor status data ArmPkg: Add register encoding definition for MMFR2 ArmPkg: Add helper to read the Memory Model Features Register 2 ArmPkg: Add helper function to read the Memory Model Feature Register 4 ArmPkg: Fix the return type of the ReadCCSIDR function ArmPkg: Update ArmLibPrivate.h with cache register definitions ArmPkg: Add definition of the maximum cache level in ARMv8-A ArmPkg: Add helper to read CCIDX status ArmPkg: Add helper to read the CCSIDR2 register ArmPkg: Add Library/OemMiscLib.h ArmPkg: Add Universal/Smbios/OemMiscLibNull ArmPkg: Add Universal/Smbios/ProcessorSubClassDxe ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type00 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type01 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type02 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type03 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type13 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32 ArmPkg: Add SMBIOS PCDs to ArmPkg.dec ArmPkg: Add Universal/Smbios/SmbiosMiscDxe ArmPkg/ArmPkg.dec | 17 + ArmPkg/ArmPkg.dsc | 5 + ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 31 + ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 66 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 89 +++ ArmPkg/Include/Chipset/AArch64.h | 4 + ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 16 + ArmPkg/Include/Library/ArmLib.h | 15 + ArmPkg/Include/Library/OemMiscLib.h | 167 +++++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 11 + ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 8 +- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 117 ++- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessor.h | 102 +++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 134 ++++ MdePkg/Include/IndustryStandard/SmBios.h | 13 + ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 19 +- ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 19 +- ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 144 ++++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 752 ++++++++++++++++++++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorAArch64.c | 93 +++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c | 99 +++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 249 +++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c | 62 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 223 ++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 93 +++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 296 ++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 36 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 196 +++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 46 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 230 ++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 52 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 224 ++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 33 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c | 166 +++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 32 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 73 ++ ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 3 + ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 16 +- ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm | 16 +- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 24 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxeStrings.uni | 22 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 18 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 20 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 20 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 18 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni | 43 ++ 47 files changed, 4126 insertions(+), 8 deletions(-) create mode 100644 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf create mode 100644 ArmPkg/Include/Library/OemMiscLib.h create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessor.h create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h create mode 100644 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorAArch64.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxeStrings.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71424): https://edk2.groups.io/g/devel/message/71424 Mute This Topic: https://groups.io/mt/80467462/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-