Got it. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Thanks Liming 发件人: bounce+27952+70609+4905953+8761...@groups.io <bounce+27952+70609+4905953+8761...@groups.io> 代表 Kun Qin 发送时间: 2021年1月21日 9:54 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn 抄送: 'Bob Feng' <bob.c.f...@intel.com>; 'Yuwei Chen' <yuwei.c...@intel.com> 主题: Re: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Hi Liming, It trips on the coding style where “Function name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters”. Please see detailed error info here: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=18722 <https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=18722&view=l ogs&j=dc79cb3a-f339-5fc0-73b1-0ff8c522379e&t=b5b21d01-2921-57ea-8401-4c0ebee 10613&l=69> &view=logs&j=dc79cb3a-f339-5fc0-73b1-0ff8c522379e&t=b5b21d01-2921-57ea-8401- 4c0ebee10613&l=69 This patch ([PATCH v3 02/18] StandaloneMmPkg: StandaloneMmCoreEntryPoint: Extends support for X64 (groups.io) <https://edk2.groups.io/g/devel/message/70332> ) added a new instance for StandaloneMmCoreEntryPoint library and failed on ECC check 8006 due to the function name involved. Regards, Kun From: gaoliming <mailto:gaolim...@byosoft.com.cn> Sent: Wednesday, January 20, 2021 17:45 To: 'Kun Qin' <mailto:ku...@outlook.com> ; devel@edk2.groups.io <mailto:devel@edk2.groups.io> Cc: 'Bob Feng' <mailto:bob.c.f...@intel.com> ; 'Yuwei Chen' <mailto:yuwei.c...@intel.com> Subject: 回复: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Qin: This change makes sense. Can you let me know which case trigs this ECC issue? Does your patch include such case? Thanks Liming 发件人: Kun Qin <ku...@outlook.com <mailto:ku...@outlook.com> > 发送时间: 2021年1月21日 9:37 收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> 抄送: Bob Feng <bob.c.f...@intel.com <mailto:bob.c.f...@intel.com> >; Liming Gao <gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn> >; Yuwei Chen <yuwei.c...@intel.com <mailto:yuwei.c...@intel.com> > 主题: RE: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Hi Bob/Liming/Yuwei, Do you mind providing some feedback on this patch? This is to unblock the second patch (adding driver entry point instance for Standalone X64) of this patch series. Thanks in advance! Regards, Kun From: Kun Qin <mailto:ku...@outlook.com> Sent: Thursday, January 14, 2021 14:34 To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> Cc: Bob Feng <mailto:bob.c.f...@intel.com> ; Liming Gao <mailto:gaolim...@byosoft.com.cn> ; Yuwei Chen <mailto:yuwei.c...@intel.com> Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Function '_ModuleEntryPoint' is a pre-defined interface for various EFI module types and should not be caught violating EFI coding style. This change added '_ModuleEntryPoint' into exception list to fix EFI coding style error 8006 during CI build. Cc: Bob Feng <bob.c.f...@intel.com <mailto:bob.c.f...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn> > Cc: Yuwei Chen <yuwei.c...@intel.com <mailto:yuwei.c...@intel.com> > Signed-off-by: Kun Qin <ku...@outlook.com <mailto:ku...@outlook.com> > --- Notes: v3: - Newly added to fix CI build on changing '_ModuleEntryPoint' BaseTools/Source/Python/Ecc/exception.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Source/Python/Ecc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml index 8133904fbc7f..f2334aab8e52 100644 --- a/BaseTools/Source/Python/Ecc/exception.xml +++ b/BaseTools/Source/Python/Ecc/exception.xml @@ -296,6 +296,10 @@ <KeyWord>_DriverUnloadHandler</KeyWord> <ErrorID>8006</ErrorID> </Exception> + <Exception> + <KeyWord>_ModuleEntryPoint</KeyWord> + <ErrorID>8006</ErrorID> + </Exception> <Exception> <KeyWord>ASSERT</KeyWord> <ErrorID>10015</ErrorID> -- 2.30.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70657): https://edk2.groups.io/g/devel/message/70657 Mute This Topic: https://groups.io/mt/80019646/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
