Jan's submission earlier today unfortunately made me go have a look at
the ARM/AARCH64 implementations, and there were plenty of other things to
improve:
- Fix comments (drop Itanium mention, correct spelling)
- Make code match existing comments
- Don't try to optimise ARM for executing on the 8088
- Use the correct register sizes on AArch64
- Actually follow the API on ARM
The changes to .asm files have been neither build nor runtime tested.
Cc: Jan Bobek <jbo...@nvidia.com>
Leif Lindholm (5):
MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations
MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations
MdePkg/BaseLib: use normal register init in ARM SetJump
implementations
MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump
MdePkg/BaseLib: ensure ARM LongJump never returns 0
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 14 ++++++++------
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 14 ++++++++------
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 10 +++++++---
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 10 +++++++---
4 files changed, 30 insertions(+), 18 deletions(-)
--
2.20.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65812): https://edk2.groups.io/g/devel/message/65812
Mute This Topic: https://groups.io/mt/77247139/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
