Hi Bob & Liming, Could you help review this patch? Thanks.
Best, Aaron > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Aaron Li > Sent: Thursday, September 17, 2020 1:58 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C <bob.c.f...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn> > Subject: [edk2-devel] [PATCH v1 1/1] Tools/FitGen: Fix microcode alignment > support > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2971 > > This patch is to fix a issue that "-A" option would only support > 2^n Byte alignment of microcode. > > Signed-off-by: Aaron Li <aaron...@intel.com> > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > --- > Silicon/Intel/Tools/FitGen/FitGen.c | 2 +- > Silicon/Intel/Tools/FitGen/FitGen.h | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c > b/Silicon/Intel/Tools/FitGen/FitGen.c > index c4006e69c822..4caaf70ee018 100644 > --- a/Silicon/Intel/Tools/FitGen/FitGen.c > +++ b/Silicon/Intel/Tools/FitGen/FitGen.c > @@ -1176,7 +1176,7 @@ Returns: > // MCU might be put at 2KB alignment, if so, we need to > adjust the > size as 2KB alignment. > > // > > if (gFitTableContext.MicrocodeIsAligned) { > > - MicrocodeSize = (*(UINT32 *)(MicrocodeBuffer + 32) + > (gFitTableContext.MicrocodeAlignValue - 1)) & > ~(gFitTableContext.MicrocodeAlignValue - 1); > > + MicrocodeSize = ROUNDUP (*(UINT32 *)(MicrocodeBuffer + 32), > gFitTableContext.MicrocodeAlignValue); > > } else { > > MicrocodeSize = (*(UINT32 *)(MicrocodeBuffer + 32)); > > } > > diff --git a/Silicon/Intel/Tools/FitGen/FitGen.h > b/Silicon/Intel/Tools/FitGen/FitGen.h > index abad2d8799c8..435fc26209da 100644 > --- a/Silicon/Intel/Tools/FitGen/FitGen.h > +++ b/Silicon/Intel/Tools/FitGen/FitGen.h > @@ -31,7 +31,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > // Utility version information > > // > > #define UTILITY_MAJOR_VERSION 0 > > -#define UTILITY_MINOR_VERSION 62 > > +#define UTILITY_MINOR_VERSION 63 > > #define UTILITY_DATE __DATE__ > > > > // > > @@ -45,4 +45,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > (ActualSize) + (((Alignment) - ((ActualSize) & ((Alignment) - 1))) & > ((Alignment) - 1)) > > ; > > > > +#define ROUNDUP(Size, Alignment) (((Size) + (Alignment) - 1) / (Alignment) > * (Alignment)) > > + > > #endif > > -- > 2.23.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#65353): https://edk2.groups.io/g/devel/message/65353 > Mute This Topic: https://groups.io/mt/76904091/4128994 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [aaron...@intel.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65414): https://edk2.groups.io/g/devel/message/65414 Mute This Topic: https://groups.io/mt/76904091/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
