It might be worth sourcing public documentation, if you have any, indicating where these numeric values ultimately come from (the offset for absolute zero is easy to figure out, but the rest, not so much).

Apart from that:

On 2020.09.10 00:11, Jeremy Linton wrote:
The current mainline DT indicates that the thermal offset
on the rpi is 410040 rather than the 419949 being used.
This means our temp calculation is offset nearly 10C higher
when running in ACPI mode vs DT.

Signed-off-by: Jeremy Linton <jeremy.lin...@arm.com>
---
  Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl 
b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
index 2b9e8211cf..d116f965e1 100644
--- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl
+++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
@@ -269,7 +269,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI", 2)
            Field (TEMS, DWordAcc, NoLock, Preserve) {

              TMPS, 32

            }

-          return (((419949 - ((TMPS & 0x3ff) * 487)) / 100) + 2732);

+          return (((410040 - ((TMPS & 0x3ff) * 487)) / 100) + 2732);

          }

          Method (_SCP, 3) { }               // receive cooling policy from OS


Reviewed-by: Pete Batard <p...@akeo.ie>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#65195): https://edk2.groups.io/g/devel/message/65195
Mute This Topic: https://groups.io/mt/76744696/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to