Laszlo: Thanks! I will merge it. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Thanks Liming > -----邮件原件----- > 发件人: bounce+27952+64998+4905953+8761...@groups.io > <bounce+27952+64998+4905953+8761...@groups.io> 代表 Laszlo Ersek > 发送时间: 2020年9月3日 16:08 > 收件人: devel@edk2.groups.io; shenglei.zh...@intel.com > 抄送: Sean Brogan <sean.bro...@microsoft.com>; Bret Barkelew > <bret.barke...@microsoft.com>; Michael D Kinney > <michael.d.kin...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn> > 主题: Re: [edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc error > code 10014 for open CI" > > On 09/03/20 08:56, Zhang, Shenglei wrote: > > This reverts commit d4e0b9607c9a64a8eff20724b2e35ea2cd5bd33f. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2951 > > Previously false positive Ecc issue whose error code is 10014 was reported > > under Linux OS. So we disabled it in EccCheck plugin for edk2 open CI. > > As the bug is fixed, we need to revert the change and re-enbale it. > > > > Cc: Sean Brogan <sean.bro...@microsoft.com> > > Cc: Bret Barkelew <bret.barke...@microsoft.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > > --- > > .pytool/Plugin/EccCheck/EccCheck.py | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/.pytool/Plugin/EccCheck/EccCheck.py > b/.pytool/Plugin/EccCheck/EccCheck.py > > index 3eaad0bf5623..eee1ff7a77b5 100644 > > --- a/.pytool/Plugin/EccCheck/EccCheck.py > > +++ b/.pytool/Plugin/EccCheck/EccCheck.py > > @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin): > > "10011", > > "10012", > > "10013", > > - "10014", #need to be removed after > BZ2904 is fixed > > "10015", > > "10016", > > "10017", > > > > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > > Liming, can you please merge this? If so, please fix a typo in the > commit message: "re-enbale" should be "re-enable". > > Thanks! > Laszlo > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64999): https://edk2.groups.io/g/devel/message/64999 Mute This Topic: https://groups.io/mt/76602305/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
