Awesome. That gives me a little time. Thanks, Jiewen! And thanks for tracking the issue.
- Bret From: Yao, Jiewen<mailto:jiewen....@intel.com> Sent: Thursday, August 20, 2020 11:16 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret Barkelew<mailto:bret.barke...@microsoft.com>; Zhang, Qi1<mailto:qi1.zh...@intel.com> Cc: Wang, Jian J<mailto:jian.j.w...@intel.com>; Wu, Hao A<mailto:hao.a...@intel.com>; Chiu, Chasel<mailto:chasel.c...@intel.com>; Desimone, Nathaniel L<mailto:nathaniel.l.desim...@intel.com>; Zeng, Star<mailto:star.z...@intel.com> Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement We are in SFF. I posted to https://github.com/jyao1/edk2/tree/FspManifestNew<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjyao1%2Fedk2%2Ftree%2FFspManifestNew&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cd02c50d3869e4b8a202908d84599aaf2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637335873591355310&sdata=5k7AJs%2Bs1R7OrnWF6AKwcYJEJEquhoXbXpf5kKOFRBQ%3D&reserved=0> temporarily. Please let us know if you have any feedback. I plan to post after the 202008 stable tag. Thank you Yao Jiewen From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bret Barkelew via groups.io Sent: Friday, August 21, 2020 1:56 PM To: devel@edk2.groups.io; Zhang, Qi1 <qi1.zh...@intel.com> Cc: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement Does this live in a branch somewhere? I'd like to take a look at it and make sure it fully replaces our current custom solution. Thanks! - Bret From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Qi Zhang via groups.io <qi1.zhang=intel....@groups.io<mailto:qi1.zhang=intel....@groups.io>> Sent: Monday, August 17, 2020 11:26 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: Qi Zhang <qi1.zh...@intel.com<mailto:qi1.zh...@intel.com>>; Yao, Jiewen <jiewen....@intel.com<mailto:jiewen....@intel.com>>; Jian J Wang <jian.j.w...@intel.com<mailto:jian.j.w...@intel.com>>; Hao A Wu <hao.a...@intel.com<mailto:hao.a...@intel.com>>; Chasel Chiu <chasel.c...@intel.com<mailto:chasel.c...@intel.com>>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com<mailto:nathaniel.l.desim...@intel.com>>; Star Zeng <star.z...@intel.com<mailto:star.z...@intel.com>> Subject: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement v4 change: rename FvEventLogRecordLib to TcgEventLogRecordLib. v3 change: add a new lib FvEventLogRecordLib for gerneric code. REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2376&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C0a458f4d4eea4c503fe908d8433fa25d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637333287874367194&sdata=SGpI04kc3Tcoo36CQ903bnTN2NFPUxoc8YzIwzIdfcs%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2376&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cd02c50d3869e4b8a202908d84599aaf2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637335873591355310&sdata=dAoro6JzLcpbZKF3xZrbf%2B2w2k8rZgfQMtcL5A8DiVc%3D&reserved=0> The EDKII BIOS calls FSP API in FSP Wrapper Pkg. This FSP code need to be measured into TPM. We need add a generic module in FSP Wrapper Pkg code to measure: 1) FSP-T, FSP-M, FSP-S in API mode. 2) FSP-T in Dispatch-mode. The FSP-M and FSP-S will be reported as standard FV and they will be measured by TCG-PEI. Cc: Jiewen Yao <jiewen....@intel.com<mailto:jiewen....@intel.com>> Cc: Jian J Wang <jian.j.w...@intel.com<mailto:jian.j.w...@intel.com>> Cc: Hao A Wu <hao.a...@intel.com<mailto:hao.a...@intel.com>> Cc: Chasel Chiu <chasel.c...@intel.com<mailto:chasel.c...@intel.com>> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com<mailto:nathaniel.l.desim...@intel.com>> Cc: Star Zeng <star.z...@intel.com<mailto:star.z...@intel.com>> Cc: Qi Zhang <qi1.zh...@intel.com<mailto:qi1.zh...@intel.com>> Jiewen Yao (4): IntelFsp2WrapperPkg/FspMeasurementLib: Add header file. IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib. IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement. IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and PcdFspMeasurementConfig. Qi Zhang (4): SecurityPkg/TcgEventLogRecordLib: add new lib for firmware measurement SecurityPkg/dsc: add FvEventLogRecordLib SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib .../FspmWrapperPeim/FspmWrapperPeim.c | 90 ++++++- .../FspmWrapperPeim/FspmWrapperPeim.inf | 20 +- .../FspsWrapperPeim/FspsWrapperPeim.c | 86 +++++- .../FspsWrapperPeim/FspsWrapperPeim.inf | 27 +- .../Include/Library/FspMeasurementLib.h | 39 +++ IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 17 ++ IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 10 +- .../BaseFspMeasurementLib.inf | 54 ++++ .../BaseFspMeasurementLib/FspMeasurementLib.c | 248 ++++++++++++++++++ .../Include/Library/TcgEventLogRecordLib.h | 97 +++++++ SecurityPkg/Include/Ppi/Tcg.h | 5 + .../TcgEventLogRecordLib.c | 197 ++++++++++++++ .../TcgEventLogRecordLib.inf | 40 +++ .../TcgEventLogRecordLib.uni | 17 ++ SecurityPkg/SecurityPkg.dec | 3 + SecurityPkg/SecurityPkg.dsc | 2 + SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 12 +- 17 files changed, 939 insertions(+), 25 deletions(-) create mode 100644 IntelFsp2WrapperPkg/Include/Library/FspMeasurementLib.h create mode 100644 IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf create mode 100644 IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c create mode 100644 SecurityPkg/Include/Library/TcgEventLogRecordLib.h create mode 100644 SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.c create mode 100644 SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf create mode 100644 SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.uni -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64526): https://edk2.groups.io/g/devel/message/64526 Mute This Topic: https://groups.io/mt/76324169/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
