Reviewed-by: Eric Dong <[email protected]> > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of > Lendacky, Thomas > Sent: Thursday, August 20, 2020 10:53 PM > To: [email protected] > Cc: Gao, Liming <[email protected]>; Dong, Eric <[email protected]>; > Ni, Ray <[email protected]>; Laszlo Ersek <[email protected]>; Kumar, > Rahul1 <[email protected]> > Subject: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize > the DoDecrement variable > > From: Tom Lendacky <[email protected]> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2901 > > The DoDecrement variable in ApWakeupFunction () wasn't always being > initialized. Update the code to always fully initialize it. > > Cc: Eric Dong <[email protected]> > Cc: Ray Ni <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Cc: Rahul Kumar <[email protected]> > Signed-off-by: Tom Lendacky <[email protected]> > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c > b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 90416c81b616..07426274f639 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -885,9 +885,7 @@ ApWakeupFunction ( > UINT64 Status; > BOOLEAN DoDecrement; > > - if (CpuMpData->InitFlag == ApInitConfig) { > - DoDecrement = TRUE; > - } > + DoDecrement = (BOOLEAN) (CpuMpData->InitFlag == > + ApInitConfig); > > while (TRUE) { > Msr.GhcbPhysicalAddress = AsmReadMsr64 (MSR_SEV_ES_GHCB); > -- > 2.28.0 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64515): https://edk2.groups.io/g/devel/message/64515 Mute This Topic: https://groups.io/mt/76309738/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
