Hi Matthew, On 08/12/20 04:21, matthewfcarl...@gmail.com wrote: > From: Matthew Carlson <mac...@microsoft.com> > > Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the > TimerLib. This is due to a later change that adds TimerLib as a dependency > for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL > previously and it is recommended to switch to a better source of > entropy than the system's performance counter. > > Ref: https://github.com/tianocore/edk2/pull/845 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Ard Biesheuvel <ard.biesheu...@arm.com> > Cc: Leif Lindholm <l...@nuviainc.com> > Signed-off-by: Matthew Carlson <matthewfcarl...@gmail.com> > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index cf44fc73890b..ddfcd0cf9eee 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -42,6 +42,7 @@ > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf >
I think you must have missed my feedback on the ArmVirtPkg patch here: https://edk2.groups.io/g/devel/message/63997 c5470af9-68a3-1d74-5cef-d88f9c54b476@redhat.com">http://mid.mail-archive.com/c5470af9-68a3-1d74-5cef-d88f9c54b476@redhat.com Basically, please move the RngLib class resolution just below the OpensslLib class resolution(s) in "ArmVirtPkg/ArmVirt.dsc.inc" as well, not just in the OVMF DSC files. Thank you! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64064): https://edk2.groups.io/g/devel/message/64064 Mute This Topic: https://groups.io/mt/76140306/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
