Sure. I would keep all the R-B because there is no other changes except the order and subject.
Thanks, Zhichao > -----Original Message----- > From: Wu, Hao A <hao.a...@intel.com> > Sent: Tuesday, August 4, 2020 9:02 AM > To: Gao, Zhichao <zhichao....@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming <liming....@intel.com>; > Ni, Ray <ray...@intel.com>; Bi, Dandan <dandan...@intel.com>; Zeng, Star > <star.z...@intel.com> > Subject: RE: [PATCH V3] Maintainers.txt: Add reviewer for serial and disk > > > -----Original Message----- > > From: Gao, Zhichao <zhichao....@intel.com> > > Sent: Monday, August 3, 2020 2:05 PM > > To: devel@edk2.groups.io > > Cc: Gao, Zhichao <zhichao....@intel.com>; Wang, Jian J > > <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Gao, Liming > > <liming....@intel.com>; Ni, Ray <ray...@intel.com>; Bi, Dandan > > <dandan...@intel.com>; Zeng, Star <star.z...@intel.com> > > Subject: [PATCH V3] Maintainers.txt: Add reviewer for serial and disk > > > Sorry, forgot to mention that please keep the newly added fields in > alphabetical > order. > > Also, please help to reflect the SMBIOS change in the subject as well. > > With them handled, > Reviewed-by: Hao A Wu <hao.a...@intel.com> > > There is no need to send out a new version of the patch if there is no comment > from others. > > Best Regards, > Hao Wu > > > > > > From: "Gao, Zhichao" <zhichao....@intel.com> > > > > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Hao A Wu <hao.a...@intel.com> > > Cc: Liming Gao <liming....@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Dandan Bi <dandan...@intel.com> > > Cc: Star Zeng <star.z...@intel.com> > > --- > > V2: > > Forget to remove the *SerailPort*.h from the common device section in V1. > > Fix it in V2. > > > > V3: > > Add the missing ':' in V2 for Disk mdoules. > > Add one more module reviewer for SMBIOS. > > > > Maintainers.txt | 17 ++++++++++++++--- > > 1 file changed, 14 insertions(+), 3 deletions(-) > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > 5504bb3d17..fe7f04831f > > 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -286,16 +286,27 @@ F: > > MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c > > R: Dandan Bi <dandan...@intel.com> > > R: Liming Gao <liming....@intel.com> > > > > +MdeModulePkg: Serial modules > > +F: MdeModulePkg/*Serial*/ > > +F: MdeModulePkg/Include/*SerialPort*.h > > +R: Hao A Wu <hao.a...@intel.com> > > +R: Ray Ni <ray...@intel.com> > > +R: Zhichao Gao <zhichao....@intel.com> > > + > > +MdeModulePkg: Disk modules > > +F: MdeModulePkg/Universal/Disk/ > > +R: Hao A Wu <hao.a...@intel.com> > > +R: Ray Ni <ray...@intel.com> > > +R: Zhichao Gao <zhichao....@intel.com> > > + > > MdeModulePkg: Device and Peripheral modules > > F: MdeModulePkg/*PciHostBridge*/ > > -F: MdeModulePkg/*Serial*/ > > F: MdeModulePkg/Bus/ > > F: MdeModulePkg/Include/*Ata*.h > > F: MdeModulePkg/Include/*IoMmu*.h > > F: MdeModulePkg/Include/*NonDiscoverableDevice*.h > > F: MdeModulePkg/Include/*NvmExpress*.h > > F: MdeModulePkg/Include/*SdMmc*.h > > -F: MdeModulePkg/Include/*SerialPort*.h > > F: MdeModulePkg/Include/*Ufs*.h > > F: MdeModulePkg/Include/*Usb*.h > > F: MdeModulePkg/Include/Guid/RecoveryDevice.h > > @@ -304,7 +315,6 @@ F: > > MdeModulePkg/Include/Library/PciHostBridgeLib.h > > F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h > > F: MdeModulePkg/Include/Protocol/Ps2Policy.h > > F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/ > > -F: MdeModulePkg/Universal/Disk/ > > F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/ > > R: Hao A Wu <hao.a...@intel.com> > > R: Ray Ni <ray...@intel.com> > > @@ -365,6 +375,7 @@ MdeModulePkg: SMBIOS modules > > F: MdeModulePkg/Universal/Smbios*/ > > R: Dandan Bi <dandan...@intel.com> > > R: Star Zeng <star.z...@intel.com> > > +R: Zhichao Gao <zhichao....@intel.com> > > > > MdeModulePkg: UEFI Variable modules > > F: MdeModulePkg/*Var*/ > > -- > > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63685): https://edk2.groups.io/g/devel/message/63685 Mute This Topic: https://groups.io/mt/75960401/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
