Shenglei: I have one comment. Seemly, LicenseCheck_plug_in.yaml copyright may be Intel one.
Reviewed-by: Liming Gao <[email protected]> for this patch set. Thanks Liming -----Original Message----- From: Zhang, Shenglei <[email protected]> Sent: 2020年7月20日 16:37 To: [email protected] Cc: Kinney, Michael D <[email protected]>; Sean Brogan <[email protected]>; Bret Barkelew <[email protected]>; Dong, Eric <[email protected]>; Laszlo Ersek <[email protected]>; Gao, Zhichao <[email protected]>; Yao, Jiewen <[email protected]>; Chao Zhang <[email protected]>; Justen, Jordan L <[email protected]>; Maciej Rabeda <[email protected]>; Wu, Jiaxin <[email protected]>; Fu, Siyuan <[email protected]>; Gao, Liming <[email protected]>; Wang, Jian J <[email protected]>; Wu, Hao A <[email protected]>; Andrew Fish <[email protected]>; Ni, Ray <[email protected]>; Lu, XiaoyuX <[email protected]>; Ard Biesheuvel <[email protected]>; Leif Lindholm <[email protected]> Subject: [PATCH 00/15] Add a plugin LicenseCheck in open ci REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833 LicenseCheck is now enabled in PatchCheck.py. But there's a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'" to suggest revert the change.These patch series introduce a plugin LicenseCheck into open ci so that license issues can still be checked after the checker is disabled in PatchCheck.py. 1/15 is the plugin implementation. 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow developers to skip license check for some files like generated files. Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can pass this checker. Cc: Michael D Kinney <[email protected]> Cc: Sean Brogan <[email protected]> Cc: Bret Barkelew <[email protected]> Cc: Eric Dong <[email protected]> Cc: Laszlo Ersek <[email protected]> Cc: Zhichao Gao <[email protected]> Cc: Jiewen Yao <[email protected]> Cc: Chao Zhang <[email protected]> Cc: Jordan Justen <[email protected]> Cc: Maciej Rabeda <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Siyuan Fu <[email protected]> Cc: Liming Gao <[email protected]> Cc: Jian J Wang <[email protected]> Cc: Hao A Wu <[email protected]> Cc: Jordan Justen <[email protected]> Cc: Andrew Fish <[email protected]> Cc: Ray Ni <[email protected]> Cc: Jian J Wang <[email protected]> Cc: Xiaoyu Lu <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: Leif Lindholm <[email protected]> Shenglei Zhang (15): .pytool/Plugin: Add a plugin LicenseCheck FatPkg/FatPkg.ci.yaml: Add configuration for LicenseCheck ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for LicenseCheck CryptoPkg/CryptoPkg.ci.yaml: Add configuration for LicenseCheck EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for LicenseCheck FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for LicenseCheck MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for LicenseCheck MdePkg/MdePkg.ci.yaml: Add configuration for LicenseCheck NetworkPkg/NetworkPkg.ci.yaml: Add configuration for LicenseCheck OvmfPkg/OvmfPkg.ci.yaml: Add configuration for LicenseCheck PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for LicenseCheck SecurityPkg/SecurityPkg.ci.yaml: Add configuration for LicenseCheck ShellPkg/ShellPkg.ci.yaml: Add configuration for LicenseCheck UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for LicenseCheck UnitTestFrameworkPkg: Add configuration for LicenseCheck in yaml file .pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 ++++++++++++++++++ .../LicenseCheck/LicenseCheck_plug_in.yaml | 11 ++ .pytool/Plugin/LicenseCheck/Readme.md | 17 +++ ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 + CryptoPkg/CryptoPkg.ci.yaml | 3 + EmulatorPkg/EmulatorPkg.ci.yaml | 4 + FatPkg/FatPkg.ci.yaml | 3 + FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 + MdeModulePkg/MdeModulePkg.ci.yaml | 4 + MdePkg/MdePkg.ci.yaml | 4 + NetworkPkg/NetworkPkg.ci.yaml | 3 + OvmfPkg/OvmfPkg.ci.yaml | 4 + PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 + SecurityPkg/SecurityPkg.ci.yaml | 3 + ShellPkg/ShellPkg.ci.yaml | 3 + UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 + .../UnitTestFrameworkPkg.ci.yaml | 4 + 17 files changed, 194 insertions(+) create mode 100644 .pytool/Plugin/LicenseCheck/LicenseCheck.py create mode 100644 .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml create mode 100644 .pytool/Plugin/LicenseCheck/Readme.md -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63281): https://edk2.groups.io/g/devel/message/63281 Mute This Topic: https://groups.io/mt/75678207/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
