Thank you very much, Qi. I forgot to mention that we should change the name EFI_TCG2_PRE_HASH to EDKII_TCG_PRE_HASH. The EFI_* prefix is only for standard defined protocol/PPI. Since this is our EDKII extension, we should use EDKII_* prefix.
With that change, the series: Reviewed-by: Jiewen Yao <jiewen....@intel.com> > -----Original Message----- > From: Zhang, Qi1 <qi1.zh...@intel.com> > Sent: Friday, July 17, 2020 3:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 <qi1.zh...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; > Wang, Jian J <jian.j.w...@intel.com>; Chao Zhang <chao.b.zh...@intel.com>; > Kumar, Rahul1 <rahul1.ku...@intel.com> > Subject: [PATCH v3 0/6] Add capability to let PEIM extend TcgEvent > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 > > Currently, we have TCG/TCG2 protocol and DxeTpmMeasurementLib to let DXE > module extend the TCG event. > There is more and more use case in PEI phase that a PEIM need extend TCG > event, such as BootGuard, FSP, Microcode measurement. Currently, we dont > have API to do that so that each module need create TCG/TCG2 event log, > which is a burden. > > This bugzilla requests to add PeiTpmMeasurementLib instance. > > The implementation includes: > 1) A EDKII_TCG_PPI which abstracts the HashLogExtendEvent service. > 2) A PeiTpmMeasurementLib instance, so that a PEIM can call this API to > add TCG event. > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Chao Zhang <chao.b.zh...@intel.com> > Cc: Qi Zhang <qi1.zh...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > > Jiewen Yao (6): > SecurityPkg/TcgPpi: Add TcgPpi header file. > SecurityPkg/dec: Add TcgPpi. > SecurityPkg/Tcg: Add TcgPpi > SecurityPkg/Tcg2: Add TcgPpi > SecurityPkg/PeiTpmMeasurementLib: Add PEI instance. > SecurityPkg/dsc: Add PeiTpmMeasurementLib. > > SecurityPkg/Include/Ppi/Tcg.h | 60 ++++++++++ > .../PeiTpmMeasurementLib.c | 74 ++++++++++++ > .../PeiTpmMeasurementLib.inf | 50 ++++++++ > .../PeiTpmMeasurementLib.uni | 17 +++ > SecurityPkg/SecurityPkg.dec | 3 + > SecurityPkg/SecurityPkg.dsc | 4 +- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 110 +++++++++++++----- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 3 +- > SecurityPkg/Tcg/TcgPei/TcgPei.c | 61 +++++++++- > SecurityPkg/Tcg/TcgPei/TcgPei.inf | 3 +- > 10 files changed, 351 insertions(+), 34 deletions(-) > create mode 100644 SecurityPkg/Include/Ppi/Tcg.h > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.c > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf > create mode 100644 > SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.uni > > -- > 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62736): https://edk2.groups.io/g/devel/message/62736 Mute This Topic: https://groups.io/mt/75607814/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
