As I mentioned in the previous comments, could you please CC all UefiPayloadPkg maintainers listed in the Maintainers.txt under the root of the EDK2 directory for code changes in UefiPayloadPkg ?
Other than that, this patch looks good to me. Reviewed-by: Maurice Ma <maurice...@intel.com> Thanks Maurice > -----Original Message----- > From: Marcello Sylvester Bauer <marcello.ba...@9elements.com> > Sent: Monday, July 13, 2020 1:25 > To: devel@edk2.groups.io > Cc: Patrick Rudolph <patrick.rudo...@9elements.com>; Christian Walter > <christian.wal...@9elements.com>; Ma, Maurice <maurice...@intel.com>; > Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Zeng, Star > <star.z...@intel.com> > Subject: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults > > From: Patrick Rudolph <patrick.rudo...@9elements.com> > > The BaseSerialPortLib16550 does fallback to a fixed address UART defined by > PcdSerialRegisterBase and does not initialize if it is zero. Do not assume a > serial > port at 0x3F8, otherwise it could cause errors during initialisation of a non- > existent serial port on non legacy platforms. > > Signed-off-by: Patrick Rudolph <patrick.rudo...@9elements.com> > Signed-off-by: Marcello Sylvester Bauer <marcello.ba...@9elements.com> > Cc: Patrick Rudolph <patrick.rudo...@9elements.com> > Cc: Christian Walter <christian.wal...@9elements.com> > Cc: Maurice Ma <maurice...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > --- > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +- > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index 0efcfa8fb2f4..0d8854810700 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common] > # The following parameters are set by Library/PlatformHookLib # > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE- > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8+ > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE) > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1 diff --git > a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index d645d233cd08..34640b1fc1da 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common] > # The following parameters are set by Library/PlatformHookLib # > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE- > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8+ > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE) > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1 -- > 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62430): https://edk2.groups.io/g/devel/message/62430 Mute This Topic: https://groups.io/mt/75472935/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
