Hi, On 07/13/20 12:22, Marcello Sylvester Bauer wrote: > From: Patrick Rudolph <patrick.rudo...@9elements.com> > > The Option ROM scanner can't work as enumeration was done by the > first stage bootloader. Running it will disable the ability of the > PCIPlatform code to scan for ROMs. > > Required for the following patch that enables custom Option ROM > scanning using gPciPlatformProtocol. > > Signed-off-by: Patrick Rudolph <patrick.rudo...@9elements.com> > Signed-off-by: Marcello Sylvester Bauer <marcello.ba...@9elements.com> > Cc: Patrick Rudolph <patrick.rudo...@9elements.com> > Cc: Christian Walter <christian.wal...@9elements.com> > Cc: Maurice Ma <maurice...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-)
Please don't forget to CC the maintainers / designated reviewers of this code. $ python BaseTools/Scripts/GetMaintainer.py \ -l MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c Jian J Wang <jian.j.w...@intel.com> Hao A Wu <hao.a...@intel.com> Ray Ni <ray...@intel.com> devel@edk2.groups.io I'm adding Jian, Hao, and Ray now. Also CC'ing Anthony and Julien, because OVMF runs on Xen with PcdPciDisableBusEnumeration=TRUE, and this patch changes behavior in that case. Thanks Laszlo > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > index 6c68a97d4e46..7420f0079f7d 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > @@ -2530,10 +2530,12 @@ PciEnumeratorLight ( > // > RemoveRejectedPciDevices (RootBridgeDev->Handle, RootBridgeDev); > > - // > - // Process option rom light > - // > - ProcessOptionRomLight (RootBridgeDev); > + if (!PcdGetBool (PcdPciDisableBusEnumeration)) { > + // > + // Process option rom light > + // > + ProcessOptionRomLight (RootBridgeDev); > + } > > // > // Determine attributes for all devices under this root bridge > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62429): https://edk2.groups.io/g/devel/message/62429 Mute This Topic: https://groups.io/mt/75474021/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-