On 7/2/20 2:04 AM, Dong, Eric wrote: > Hi Tom, Hi Eric,
> > We have root cause this Mac file format issue. The patch mail from your side > include extra two "=0D=0D" , and our test tool convert them to "\r\r". This > is Mac file line ending format. So this issue been reported. We have updated > our tool to handle this special case. Good to know, thanks! > > With that change, now I met below error when use VS2015 tool chain. Can you > help to fix it? > > Building ... > g:\edk2-open-source\edk2\MdePkg\Library\PeiCoreEntryPoint\PeiCoreEntryPoint.inf > [X64] > PeCoffLoaderEx.c > g:\edk2-open-source\edk2\OvmfPkg\Library\VmgExitLib\VmgExitVcHandler.c(386): > warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio > 14.0\Vc\bin\x86_amd64\cl.exe"' : return code '0x2' Yup, looks like that needs to be a "1ULL <<" instead of "1 <<". I have verified that fixes the issue. One thing I noticed is that the 32-bit builds (PlatformCI_OvmfPkg_Windows_VS2019_PR, Platform_CI OVMF_IA32_NOOPT and Platform_CI OVMF_IA32X64_NOOPT) encounter an error: ERROR - Linker #2001 from SecMain.lib(SecMain.obj) : unresolved external symbol __allshl ERROR - Linker #1120 from d:\a\1\s\Build\Ovmf3264\NOOPT_VS2019\IA32\OvmfPkg\Sec\SecMain\DEBUG\SecMain.dll : fatal 1 unresolved externals ERROR - Compiler #1077 from NMAKE : fatal '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.26.28801\bin\Hostx86\x86\link.exe"' : return code '0x460' Any idea what is causing this error? Thanks, Tom > > Thanks, > Eric >> -----Original Message----- >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of >> Lendacky, Thomas >> Sent: Tuesday, June 23, 2020 8:58 PM >> To: devel@edk2.groups.io; Dong, Eric <eric.d...@intel.com>; >> ler...@redhat.com >> Cc: Brijesh Singh <brijesh.si...@amd.com>; Ard Biesheuvel >> <ard.biesheu...@arm.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; >> Gao, Liming <liming....@intel.com>; Kinney, Michael D >> <michael.d.kin...@intel.com>; Ni, Ray <ray...@intel.com> >> Subject: Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement library >> support for VMGEXIT >> >> On 6/22/20 8:16 PM, Dong, Eric via groups.io wrote: >>> >>> >>>> -----Original Message----- >>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of >> Laszlo >>>> Ersek >>>> Sent: Friday, June 19, 2020 11:39 PM >>>> To: Tom Lendacky <thomas.lenda...@amd.com>; devel@edk2.groups.io; >>>> Dong, Eric <eric.d...@intel.com> >>>> Cc: Brijesh Singh <brijesh.si...@amd.com>; Ard Biesheuvel >>>> <ard.biesheu...@arm.com>; Justen, Jordan L >>>> <jordan.l.jus...@intel.com>; Gao, Liming <liming....@intel.com>; >>>> Kinney, Michael D <michael.d.kin...@intel.com>; Ni, Ray >>>> <ray...@intel.com> >>>> Subject: Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement >>>> library support for VMGEXIT >>>> >>>> On 06/19/20 15:50, Tom Lendacky wrote: >>>>> On 6/19/20 2:47 AM, Dong, Eric via groups.io wrote: >>>>>> >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of >>>>>>> Lendacky, Thomas >>>>>>> Sent: Thursday, June 18, 2020 10:09 PM >>>>>>> To: Dong, Eric <eric.d...@intel.com>; devel@edk2.groups.io >>>>>>> Cc: Brijesh Singh <brijesh.si...@amd.com>; Ard Biesheuvel >>>>>>> <ard.biesheu...@arm.com>; Justen, Jordan L >>>> <jordan.l.jus...@intel.com>; >>>>>>> Laszlo Ersek <ler...@redhat.com>; Gao, Liming >>>>>>> <liming....@intel.com>; Kinney, Michael D >>>>>>> <michael.d.kin...@intel.com>; Ni, Ray <ray...@intel.com> >>>>>>> Subject: Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement >>>> library >>>>>>> support for VMGEXIT >>>>>>> >>>>>>> On 6/18/20 2:23 AM, Dong, Eric wrote: >>>>>>>> Hi Tom, >>>>>>>> >>>>>>>> When use VS2015 to build this code, it reports below error. >>>>>>>> Please help to >>>>>>> fix it. >>>>>>>> >>>>>>>> k:\edk2\UefiCpuPkg\Include\Library/VmgExitLib.h: error C2220: >>>> warning >>>>>>>> treated as error - no 'object' file generated >>>>>>>> k:\edk2\UefiCpuPkg\Include\Library/VmgExitLib.h: warning C4335: >>>> Mac >>>>>>>> file format detected: please convert the source file to either >>>>>>>> DOS or UNIX format >>>>>>> >>>>>>> That is strange... I didn't see this when I ran through the CI. >>>>>>> When I do a file command against the file it reports: >>>>>>> >>>>>>> UefiCpuPkg/Include/Library/VmgExitLib.h: C source, ASCII text, >>>>>>> with >>>> CRLF >>>>>>> line terminators >>>>>>> >>>>>>> I'll investigate this and try and figure out what's going on, but >>>>>>> if anyone else has some ideas, please let me know. >>>>>> >>>>>> Hi Tom, >>>>>> >>>>>> I met this error again when I trig below patch from AMD again for >>>>>> CPU change. >>>>>> "UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to >>>> BaseUefiCpuLib" >>>>> >>>>> Hmmm... I think we could be running into issues with sending patches >>>>> through our mail servers. Let me send you the patch series directly >>>>> using some changes I made to my git config file to see if that helps. >>>>> Would that be ok? >>>> >>>> both sender and recipient git clones should have >>>> >>>> [core] >>>> whitespace = cr-at-eol >>>> >>>> and the recipient clone should have >>>> >>>> [am] >>>> keepcr = true >>>> >>>> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >>>> hub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FLaszlo%27s- >> unkempt >>>> -git- >> &data=02%7C01%7Cthomas.lendacky%40amd.com%7Cd461956236264e >> 4a >>>> >> 6d3a08d81713205d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6 >> 372847 >>>> >> 18210751789&sdata=ftFiRZkC3n2n2MZyL6t9HKnp1fYgzUQV4FRBvVNQ4 >> %2FA%3 >>>> D&reserved=0 >>>> guide-for-edk2-contributors-and-maintainers#contrib-05 >>>> >>>> These are also set by "BaseTools/Scripts/SetupGit.py". >>>> >>> >>> Hi Tom, >>> >>> I see below context in another mail thread and base on the latest status, >> this solution works and that patch has fixed the issue. Can you follow below >> suggest fixing your issue? >>> >>> Hi Garrett, >>> >>> I encounter below error when build >>> UefiCpuPkg\Library\BaseUefiCpuLib\BaseUefiCpuLib.c: warning C4335: >> Mac file format detected: please convert the source file to either DOS or >> UNIX format' >>> >>> I encounter the issue ever, it result by mail encoding. >>> To resolve this issue, you can run [BaseTools\ Scripts\SetupGit.py] first, >> and then send the patch again. >>> >>> Could you try it and send the patch again? >> >> Hi Eric, >> >> I already had those settings in my git config file, so I'm thinking it was >> still >> something else. I sent you a direct set of patches with some other setting >> tweaks. Let me know how those work out for you. >> >> Thanks, >> Tom >> >>> >>> Thanks, >>> Eric >>> >>>> Thanks >>>> Laszlo >>>> >>>> >>>> >>> >>> >>> >> >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62102): https://edk2.groups.io/g/devel/message/62102 Mute This Topic: https://groups.io/mt/74692413/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
