Hi Oleksiy, On 07/02/20 22:50, Oleksiy Yakovlev wrote: > Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO > attributes introduced in UEFI 2.8 > (UEFI 2.8, mantis 1919 and 1872) > Fix typos in EFI_MEMORY_CPU_CRYPTO description. > Add attributes bitmasks, grouped by type. > > Signed-off-by: Oleksiy Yakovlev <oleks...@ami.com> > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > Reviewed-by: Liming Gao <liming....@intel.com> > --- > MdePkg/Include/Uefi/UefiSpec.h | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-)
I think you forgot to pick up Zhiguang Liu's "Reviewed-by" from <https://edk2.groups.io/g/devel/message/61627> (i.e., under the v2 thread). Of course I think that can be remedied by the maintainer that merges this series in the end. (I can help with that too, but the series isn't fully reviewed yet -- patches v3 #2 through #4 still need maintainer approval.) Thanks, Laszlo > > diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h > index 558e1bc..05b82e0 100644 > --- a/MdePkg/Include/Uefi/UefiSpec.h > +++ b/MdePkg/Include/Uefi/UefiSpec.h > @@ -96,9 +96,9 @@ typedef enum { > #define EFI_MEMORY_SP 0x0000000000040000ULL > // > // If this flag is set, the memory region is capable of being > -// protected with the CPU?s memory cryptographic > +// protected with the CPU's memory cryptographic > // capabilities. If this flag is clear, the memory region is not > -// capable of being protected with the CPU?s memory > +// capable of being protected with the CPU's memory > // cryptographic capabilities or the CPU does not support CPU > // memory cryptographic capabilities. > // > @@ -109,6 +109,12 @@ typedef enum { > // > #define EFI_MEMORY_RUNTIME 0x8000000000000000ULL > > +// > +// Attributes bitmasks, grouped by type > +// > +#define EFI_CACHE_ATTRIBUTE_MASK (EFI_MEMORY_UC | EFI_MEMORY_WC | > EFI_MEMORY_WT | EFI_MEMORY_WB | EFI_MEMORY_UCE | EFI_MEMORY_WP) > +#define EFI_MEMORY_ATTRIBUTE_MASK (EFI_MEMORY_RP | EFI_MEMORY_XP | > EFI_MEMORY_RO | EFI_MEMORY_SP | EFI_MEMORY_CPU_CRYPTO) > + > /// > /// Memory descriptor version number. > /// > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62089): https://edk2.groups.io/g/devel/message/62089 Mute This Topic: https://groups.io/mt/75267364/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
