One minor comment.
> -----Original Message-----
> From: Oleksiy Yakovlev <oleks...@ami.com>
> Sent: Wednesday, June 24, 2020 12:29 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming....@intel.com>; Kinney, Michael D
> <michael.d.kin...@intel.com>; fel...@ami.com; oleks...@ami.com
> Subject: [PATCH] MdePkg: Add Serial Terminal Device Type Guid
>
> Add definition of EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID.
> It was miseed in "Extend SERIAL_IO with DeviceTypeGuid" patch.
> (UEFI 2.8, mantis 1832)
>
> Signed-off-by: Oleksiy Yakovlev <oleks...@ami.com>
> ---
> MdePkg/Include/Protocol/SerialIo.h | 6 ++++++
> MdePkg/MdePkg.dec | 6 ++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/MdePkg/Include/Protocol/SerialIo.h
> b/MdePkg/Include/Protocol/SerialIo.h
> index e2e0c61..16a865b 100644
> --- a/MdePkg/Include/Protocol/SerialIo.h
> +++ b/MdePkg/Include/Protocol/SerialIo.h
> @@ -17,6 +17,11 @@
> 0xBB25CF6F, 0xF1D4, 0x11D2, {0x9A, 0x0C, 0x00, 0x90, 0x27, 0x3F, 0xC1,
> 0xFD } \
> }
>
> +#define EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID \
> + { \
> + 0X6AD9A60F, 0X5815, 0X4C7C, { 0X8A, 0X10, 0X50, 0X53, 0XD2, 0XBF, 0X7A,
> 0X1B } \
> + }
> +
> ///
> /// Protocol GUID defined in EFI1.1.
> ///
> @@ -299,5 +304,6 @@ struct _EFI_SERIAL_IO_PROTOCOL {
> };
>
> extern EFI_GUID gEfiSerialIoProtocolGuid;
> +extern EFI_GUID gEfiSerialTerminalDeviceTypeGuid;
>
> #endif
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index d03fc5b..2ffb71d 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -798,6 +798,12 @@
> #
> gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6, { 0x95,
> 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
>
> + #
> + # GUID defined For Serial Io Prtotocol Devicee Type
> + #
> + ## Include/Protocol/SerilaIo.h
> + gEfiSerialTerminalDeviceTypeGuid = { 0x6AD9A60F, 0x5815, 0x4C7C, { 0x08A,
> 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }}
> +
Please define this guid below # GUIDs defined in UEFI2.8a, because it is
introduced in UEFI2.8a.
Thanks
Liming
> [Guids.IA32, Guids.X64]
> ## Include/Guid/Cper.h
> gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, { 0xAC,
> 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}
> --
> 2.9.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and proprietary
> to American Megatrends (AMI). This communication
> is intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this
> message, in any form, is strictly prohibited. Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600,
> and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#61682): https://edk2.groups.io/g/devel/message/61682
Mute This Topic: https://groups.io/mt/75063467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
