Reviewed-by: Andrei Warkentin <awarken...@vmware.com> A ________________________________ From: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> Sent: Wednesday, June 17, 2020 11:16 PM To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: Ard Biesheuvel <ard.biesheu...@arm.com>; Leif Lindholm <l...@nuviainc.com>; Andrei Warkentin <awarken...@vmware.com>; Pete Batard <p...@akeo.ie> Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix SMBIOS Type 9
FWTS reports an error with SMBIOS Type 9 Segment-Bus-DevFunc fields. The SMBIOS specification requires that for non-PCIe slot devices to have these fields reported as 0xFFFFF-0xFF-xFF. Instead, they were being reported as 0x0000-0x00-0x00. This fixes the FWTS SMBIOS Type 9 failure reported here: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpftf%2FRPi4%2Fissues%2F75&data=02%7C01%7Cawarkentin%40vmware.com%7C12c3f18cf4c542508b1008d8133e6ec5%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637280506159613646&sdata=SOdVyajdUz021jZ9PrJMTSw%2B3zef8FR88WMRp6Xckio%3D&reserved=0 Cc: Ard Biesheuvel <ard.biesheu...@arm.com> Cc: Leif Lindholm <l...@nuviainc.com> Cc: Andrei Warkentin <awarken...@vmware.com> Cc: Pete Batard <p...@akeo.ie> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c index 7b86e76a1248..78bdda18eb2d 100644 --- a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c +++ b/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c @@ -380,9 +380,9 @@ SMBIOS_TABLE_TYPE9 mSysSlotInfoType9 = { 0, // SmbusSignalSupported :1; 0, // Reserved :5; ///< Set to 0. }, - 0, // SegmentGroupNum; - 0, // BusNum; - 0, // DevFuncNum; + 0xFFFF, // SegmentGroupNum; + 0xFF, // BusNum; + 0xFF, // DevFuncNum; }; CHAR8 *mSysSlotInfoType9Strings[] = { "SD Card", -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61464): https://edk2.groups.io/g/devel/message/61464 Mute This Topic: https://groups.io/mt/74952694/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
