On 5/18/20 4:11 PM, PierreGondois via groups.io wrote:
Following the BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=2425
This patch serie is a another way to solve the dependency
of C files over ASL files. With this new method, the
dependency is resolved at the linking stage.

The last method to solve this dependency was to add
the possibility to modify INF files to depict such a
dependency. This method was not accepted. The discussion
is available at https://edk2.groups.io/g/devel/topic/72655342#56658

The last patch modifying the INF specification and INF
parsing are available at:
https://edk2.groups.io/g/devel/topic/72655342#56658
https://edk2.groups.io/g/devel/topic/72656060#56662

Pierre Gondois (3):
   BaseTools: Generate multiple rules when multiple output files
   BaseTools: Rename AmlToHex script to AmlToC
   BaseTools: Compile AML bytecode arrays into .obj file



Hello Pierre,

I have no comments on this series, but I noticed that AmlToHex was checked into the repository with CRLF line endings:

$ file BaseTools/BinWrappers/PosixLike/AmlToHex
Bourne-Again shell script, ASCII text executable, with CRLF line terminators

resulting in Build output like

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20181213
Copyright (c) 2000 - 2018 Intel Corporation

ASL Input: /home/ard/build/edk2-workspace/Build/ArmVirtQemuKernel-ARM/RELEASE_CLANG38/ARM/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe/OUTPUT/./RamDisk.iiii - 42 lines, 305 bytes, 6 keywords AML Output: /home/ard/build/edk2-workspace/Build/ArmVirtQemuKernel-ARM/RELEASE_CLANG38/ARM/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe/OUTPUT/./RamDisk.aml - 124 bytes, 5 named objects, 1 executable opcodes

Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations
/usr/bin/env: ‘bash\r’: No such file or directory


Note that this platform has no use for the hex-dumped output of the AML, so it would be better if we only call AmlToHex when necessary.

Thanks,
Ard.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61235): https://edk2.groups.io/g/devel/message/61235
Mute This Topic: https://groups.io/mt/74291745/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to