Reviewed-by: Dong, Guo <[email protected]>
Thanks, Guo > -----Original Message----- > From: Tan, Ming <[email protected]> > Sent: Tuesday, June 9, 2020 7:57 PM > To: [email protected] > Cc: Ma, Maurice <[email protected]>; Dong, Guo > <[email protected]>; You, Benjamin <[email protected]> > Subject: [PATCH v4 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change > some PCDs type > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 > > Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory > in MdeModulePkg.dec are changed, so change them from > PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. > > Cc: Maurice Ma <[email protected]> > Cc: Guo Dong <[email protected]> > Cc: Benjamin You <[email protected]> > Signed-off-by: Ming Tan <[email protected]> > --- > V4: Adjust the location of PCDs, put them after PcdVpdBaseAddress, > and make PCDs together with same TokenSpaceGuid > instead of put them in the last of section. > V3: Split one patch to several patchs, each Pkg has one patch. > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 14 +++++++------- > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 14 +++++++------- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index d52945442e0e..c6c47833871b 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -3,7 +3,7 @@ > # > # Provides drivers and definitions to create uefi payload for bootloaders. > # > -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR> > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -264,12 +264,6 @@ > [LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLIC > ATION] > # > > ########################################################## > ###################### > [PcdsFeatureFlag] > -!if $(TARGET) == DEBUG > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > -!else > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > -!endif > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > @@ -284,6 +278,12 @@ [PcdsFixedAtBuild] > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > +!if $(TARGET) == DEBUG > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > +!else > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > +!endif > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, > 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, > 0x23, 0x31 } > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|$(PCIE_BASE) > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index 0736cd995476..5559b1258521 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -3,7 +3,7 @@ > # > # Provides drivers and definitions to create uefi payload for bootloaders. > # > -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR> > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -265,12 +265,6 @@ > [LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLIC > ATION] > # > > ########################################################## > ###################### > [PcdsFeatureFlag] > -!if $(TARGET) == DEBUG > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > -!else > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > -!endif > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > @@ -285,6 +279,12 @@ [PcdsFixedAtBuild] > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > +!if $(TARGET) == DEBUG > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > +!else > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > +!endif > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, > 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, > 0x23, 0x31 } > > -- > 2.24.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61177): https://edk2.groups.io/g/devel/message/61177 Mute This Topic: https://groups.io/mt/74789488/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
